From 7791ad5af1075113952e1661c7e2cf639bf450e9 Mon Sep 17 00:00:00 2001
From: slzhou <slzhou@taosdata.com>
Date: Sun, 24 Apr 2022 14:21:07 +0800
Subject: [PATCH] try to modify and failure

---
 source/common/src/tmsg.c                   | 2 +-
 source/dnode/mnode/impl/src/mndFunc.c      | 8 ++++----
 source/dnode/mnode/impl/test/func/func.cpp | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/source/common/src/tmsg.c b/source/common/src/tmsg.c
index eb7c9a763f..dca9f05855 100644
--- a/source/common/src/tmsg.c
+++ b/source/common/src/tmsg.c
@@ -1574,7 +1574,7 @@ int32_t tSerializeSCreateFuncReq(void *buf, int32_t bufLen, SCreateFuncReq *pReq
   }
   if (tEncodeI32(&encoder, codeSize) < 0) return -1;
   if (pReq->pCode != NULL) {
-    if (tEncodeCStr(&encoder, pReq->pCode) < 0) return -1;
+    if (tEncodeBinary(&encoder, pReq->pCode, codeSize) < 0) return -1;
   }
 
   int32_t commentSize = 0;
diff --git a/source/dnode/mnode/impl/src/mndFunc.c b/source/dnode/mnode/impl/src/mndFunc.c
index 156d894a44..7cfd7d89e6 100644
--- a/source/dnode/mnode/impl/src/mndFunc.c
+++ b/source/dnode/mnode/impl/src/mndFunc.c
@@ -309,10 +309,10 @@ static int32_t mndProcessCreateFuncReq(SNodeMsg *pReq) {
     goto _OVER;
   }
 
-  if (createReq.pCode[0] == 0) {
-    terrno = TSDB_CODE_MND_INVALID_FUNC_CODE;
-    goto _OVER;
-  }
+//  if (createReq.pCode[0] == 0) {
+//    terrno = TSDB_CODE_MND_INVALID_FUNC_CODE;
+//    goto _OVER;
+//  }
 
   if (createReq.bufSize <= 0 || createReq.bufSize > TSDB_FUNC_BUF_SIZE) {
     terrno = TSDB_CODE_MND_INVALID_FUNC_BUFSIZE;
diff --git a/source/dnode/mnode/impl/test/func/func.cpp b/source/dnode/mnode/impl/test/func/func.cpp
index f234fa4cfe..6a2f5cf10c 100644
--- a/source/dnode/mnode/impl/test/func/func.cpp
+++ b/source/dnode/mnode/impl/test/func/func.cpp
@@ -453,7 +453,7 @@ TEST_F(MndTestFunc, 05_Actual_code) {
     strcpy(createReq.name, "udf1");
     char code[300] = {0};
     for (int32_t i = 0; i < sizeof(code); ++i) {
-      code[i] = i % 20;
+      code[i] = (i+1) % 20;
     }
     SetCode(&createReq, code, 300);
     SetComment(&createReq, "comment1");
@@ -507,7 +507,7 @@ TEST_F(MndTestFunc, 05_Actual_code) {
     EXPECT_EQ(pFuncInfo->signature, 5);
     EXPECT_STREQ("comment1", pFuncInfo->pComment);
     for (int32_t i = 0; i < 300; ++i) {
-        EXPECT_EQ(pFuncInfo->pCode[i], i % 20);
+        EXPECT_EQ(pFuncInfo->pCode[i], (i+1) % 20);
     }
     tFreeSRetrieveFuncRsp(&retrieveRsp);
   }