Merge pull request #16535 from taosdata/fix/dnode

enh: make cmake .. -DCMAKE_BUILD_TYPE=Release  work

source/dnode/mgmt/node_mgmt/src/dmTransport.c

@@ -301,7 +301,7 @@ int32_t dmInitServer(SDnode *pDnode) {
   SDnodeTrans *pTrans = &pDnode->trans;
 
   SRpcInit rpcInit = {0};
-  strncpy(rpcInit.localFqdn, tsLocalFqdn, strlen(tsLocalFqdn));
+  strncpy(rpcInit.localFqdn, tsLocalFqdn, TSDB_FQDN_LEN);
   rpcInit.localPort = tsServerPort;
   rpcInit.label = "DND-S";
   rpcInit.numOfThreads = tsNumOfRpcThreads;

source/libs/executor/src/executil.c

@@ -1190,7 +1190,7 @@ SqlFunctionCtx* createSqlFunctionCtx(SExprInfo* pExprInfo, int32_t numOfOutput,
           fmGetFuncExecFuncs(pCtx->functionId, &pCtx->fpSet);
         } else {
           char* udfName = pExpr->pExpr->_function.pFunctNode->functionName;
-          strncpy(pCtx->udfName, udfName, strlen(udfName));
+          strncpy(pCtx->udfName, udfName, TSDB_FUNC_NAME_LEN);
           fmGetUdafExecFuncs(pCtx->functionId, &pCtx->fpSet);
         }
         pCtx->fpSet.getEnv(pExpr->pExpr->_function.pFunctNode, &env);

source/libs/executor/src/executorimpl.c

@@ -3982,8 +3982,8 @@ SOperatorInfo* createOperatorTree(SPhysiNode* pPhyNode, SExecTaskInfo* pTaskInfo
           STableKeyInfo* pKeyInfo = taosArrayGet(pTableListInfo->pTableList, i);
           qDebug("creating stream task: add table %" PRId64, pKeyInfo->uid);
         }
-      }
 #endif
+      }
 
       pTaskInfo->schemaInfo.qsw = extractQueriedColumnSchema(&pTableScanNode->scan);
       pOperator = createStreamScanOperatorInfo(pHandle, pTableScanNode, pTagCond, pTaskInfo);
@@ -4449,7 +4449,7 @@ _complete:
   return code;
 }
 
-static void doDestroyTableList(STableListInfo* pTableqinfoList) {
+void doDestroyTableList(STableListInfo* pTableqinfoList) {
   taosArrayDestroy(pTableqinfoList->pTableList);
   taosHashCleanup(pTableqinfoList->map);
   if (pTableqinfoList->needSortTableByGroupId) {

source/libs/function/src/builtinsimpl.c

@@ -1160,6 +1160,7 @@ static int32_t findRowIndex(int32_t start, int32_t num, SColumnInfoData* pCol, c
   }
 
   ASSERT(0);
+  return 0;
 }
 
 int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {

source/libs/function/src/tudf.c

@@ -81,7 +81,7 @@ static int32_t udfSpawnUdfd(SUdfdData* pData) {
     taosDirName(path);
   #endif
   } else {
-    strncpy(path, tsProcPath, strlen(tsProcPath));
+    strncpy(path, tsProcPath, PATH_MAX);
     taosDirName(path);
   }
 #ifdef WINDOWS

source/libs/function/src/udfd.c

@@ -453,7 +453,7 @@ void udfdProcessRpcRsp(void *parent, SRpcMsg *pMsg, SEpSet *pEpSet) {
       goto _return;
     }
     taosCloseFile(&file);
-    strncpy(udf->path, path, strlen(path));
+    strncpy(udf->path, path, PATH_MAX);
     tFreeSFuncInfo(pFuncInfo);
     taosArrayDestroy(retrieveRsp.pFuncInfos);
     msgInfo->code = 0;
@@ -566,17 +566,17 @@ int32_t udfdLoadUdf(char *udfName, SUdf *udf) {
     uv_dlsym(&udf->lib, processFuncName, (void **)(&udf->aggProcFunc));
     char  startFuncName[TSDB_FUNC_NAME_LEN + 6] = {0};
     char *startSuffix = "_start";
-    strncpy(startFuncName, processFuncName, strlen(processFuncName));
+    strncpy(startFuncName, processFuncName, sizeof(startFuncName));
     strncat(startFuncName, startSuffix, strlen(startSuffix));
     uv_dlsym(&udf->lib, startFuncName, (void **)(&udf->aggStartFunc));
     char  finishFuncName[TSDB_FUNC_NAME_LEN + 7] = {0};
     char *finishSuffix = "_finish";
-    strncpy(finishFuncName, processFuncName, strlen(processFuncName));
+    strncpy(finishFuncName, processFuncName, sizeof(finishFuncName));
     strncat(finishFuncName, finishSuffix, strlen(finishSuffix));
     uv_dlsym(&udf->lib, finishFuncName, (void **)(&udf->aggFinishFunc));
     char mergeFuncName[TSDB_FUNC_NAME_LEN + 6] = {0};
     char *mergeSuffix = "_merge";
-    strncpy(finishFuncName, processFuncName, strlen(processFuncName));
+    strncpy(finishFuncName, processFuncName, sizeof(finishFuncName));
     strncat(finishFuncName, mergeSuffix, strlen(mergeSuffix));
     uv_dlsym(&udf->lib, finishFuncName, (void **)(&udf->aggMergeFunc));
   }

source/libs/index/src/indexComm.c

@@ -171,6 +171,7 @@ TExeCond tCompare(__compar_fn_t func, int8_t cmptype, void* a, void* b, int8_t d
     return tDoCompare(func, cmptype, &va, &vb);
   }
   assert(0);
+  return BREAK;
 #endif
 }
 TExeCond tDoCompare(__compar_fn_t func, int8_t comparType, void* a, void* b) {

source/libs/sync/src/syncIndexMgr.c

@@ -163,6 +163,7 @@ int64_t syncIndexMgrGetStartTime(SSyncIndexMgr *pSyncIndexMgr, const SRaftId *pR
     }
   }
   ASSERT(0);
+  return -1;
 }
 
 void syncIndexMgrSetRecvTime(SSyncIndexMgr *pSyncIndexMgr, const SRaftId *pRaftId, int64_t recvTime) {
@@ -190,6 +191,7 @@ int64_t syncIndexMgrGetRecvTime(SSyncIndexMgr *pSyncIndexMgr, const SRaftId *pRa
     }
   }
   ASSERT(0);
+  return -1;
 }
 
 // for debug -------------------
@@ -245,4 +247,5 @@ SyncTerm syncIndexMgrGetTerm(SSyncIndexMgr *pSyncIndexMgr, const SRaftId *pRaftI
     }
   }
   ASSERT(0);
+  return -1;
 }

source/libs/transport/src/trans.c

@@ -43,7 +43,7 @@ void* rpcOpen(const SRpcInit* pInit) {
     return NULL;
   }
   if (pInit->label) {
-    tstrncpy(pRpc->label, pInit->label, strlen(pInit->label) + 1);
+    tstrncpy(pRpc->label, pInit->label, TSDB_LABEL_LEN);
   }
   // register callback handle
   pRpc->cfp = pInit->cfp;

source/util/src/talgo.c

@@ -201,6 +201,7 @@ void *taosbsearch(const void *key, const void *base, int32_t nmemb, int32_t size
     return (c > 0) ? p : (midx > 0 ? p - size : NULL);
   } else {
     ASSERT(0);
+    return NULL;
   }
 }
 

source/util/src/tcompare.c

@@ -244,6 +244,7 @@ int32_t compareJsonVal(const void *pLeft, const void *pRight) {
     return 0;
   }else{
     assert(0);
+    return 0;
   }
 }
 

source/util/src/tlog.c

@@ -446,7 +446,10 @@ static inline void taosPrintLogImp(ELogLevel level, int32_t dflag, const char *b
   }
 
   if (dflag & DEBUG_SCREEN) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
     write(1, buffer, (uint32_t)len);
+#pragma GCC diagnostic pop
   }
 }
 

tests/test/c/sdbDump.c

@@ -20,6 +20,9 @@
 #include "tconfig.h"
 #include "tjson.h"
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
+
 #define TMP_DNODE_DIR           TD_TMP_DIR_PATH "dumpsdb"
 #define TMP_MNODE_DIR           TD_TMP_DIR_PATH "dumpsdb" TD_DIRSEP "mnode"
 #define TMP_SDB_DATA_DIR        TD_TMP_DIR_PATH "dumpsdb" TD_DIRSEP "mnode" TD_DIRSEP "data"
@@ -429,6 +432,7 @@ int32_t parseArgs(int32_t argc, char *argv[]) {
 
   char cmd[PATH_MAX * 2] = {0};
   snprintf(cmd, sizeof(cmd), "rm -rf %s", TMP_DNODE_DIR);
+  
   system(cmd);
 #ifdef WINDOWS
   taosMulMkDir(TMP_SDB_DATA_DIR);
@@ -467,3 +471,5 @@ int32_t main(int32_t argc, char *argv[]) {
 
   return dumpSdb();
 }
+
+#pragma GCC diagnostic pop

tests/tsim/src/simExe.c

@@ -464,7 +464,10 @@ void simStoreSystemContentResult(SScript *script, char *filename) {
     taosCloseFile(&pFile);
     char rmCmd[MAX_FILE_NAME_LEN] = {0};
     sprintf(rmCmd, "rm -f %s", filename);
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
     system(rmCmd);
+#pragma GCC diagnostic pop
   }
 }
 

tools/shell/src/shellCommand.c

@@ -510,7 +510,10 @@ int32_t shellReadCommand(char *command) {
           shellClearLineAfter(&cmd);
           break;
         case 12:  // Ctrl + L;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
           system("clear");
+#pragma GCC diagnostic pop
           shellShowOnScreen(&cmd);
           break;
         case 21:  // Ctrl + U;

tools/shell/src/shellEngine.c

@@ -62,7 +62,10 @@ int32_t shellRunSingleCommand(char *command) {
   }
 
   if (shellRegexMatch(command, "^[\t ]*clear[ \t;]*$", REG_EXTENDED | REG_ICASE)) {
-    system("clear");
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
+          system("clear");
+#pragma GCC diagnostic pop
     return 0;
   }