From 74bc4cc3f089e5628b33abb2210b6f98f2c37731 Mon Sep 17 00:00:00 2001
From: wangmm0220 <wangmm0220@gmail.com>
Date: Tue, 7 Jun 2022 15:33:37 +0800
Subject: [PATCH] fix:return false in is ture operator if result is null

---
 source/libs/scalar/src/sclvector.c    | 19 +++++++++++++++----
 tests/system-test/2-query/json_tag.py | 10 +++++++---
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/source/libs/scalar/src/sclvector.c b/source/libs/scalar/src/sclvector.c
index 747da673d1..59208de3c4 100644
--- a/source/libs/scalar/src/sclvector.c
+++ b/source/libs/scalar/src/sclvector.c
@@ -373,9 +373,6 @@ static FORCE_INLINE void ncharToVar(char* buf, SScalarParam* pOut, int32_t rowIn
 
 //TODO opt performance, tmp is not needed.
 int32_t vectorConvertFromVarData(const SScalarParam* pIn, SScalarParam* pOut, int32_t inType, int32_t outType) {
-  int32_t bufSize = pIn->columnData->info.bytes;
-  char *tmp = taosMemoryMalloc(bufSize + VARSTR_HEADER_SIZE);
-
   bool vton = false;
 
   _bufConverteFunc func = NULL;
@@ -423,6 +420,12 @@ int32_t vectorConvertFromVarData(const SScalarParam* pIn, SScalarParam* pOut, in
         continue;
       }
     }
+    int32_t bufSize = pIn->columnData->info.bytes;
+    char *tmp = taosMemoryMalloc(varDataTLen(data));
+    if(!tmp){
+      sclError("out of memory in vectorConvertFromVarData");
+      return TSDB_CODE_OUT_OF_MEMORY;
+    }
     if (vton) {
       memcpy(tmp, data, varDataTLen(data));
     } else {
@@ -444,9 +447,9 @@ int32_t vectorConvertFromVarData(const SScalarParam* pIn, SScalarParam* pOut, in
     }
     
     (*func)(tmp, pOut, i);
+    taosMemoryFreeClear(tmp);
   }
   
-  taosMemoryFreeClear(tmp);
   return TSDB_CODE_SUCCESS;
 }
 
@@ -1674,6 +1677,14 @@ void vectorNotNull(SScalarParam* pLeft, SScalarParam* pRight, SScalarParam *pOut
 
 void vectorIsTrue(SScalarParam* pLeft, SScalarParam* pRight, SScalarParam *pOut, int32_t _ord) {
   vectorConvertImpl(pLeft, pOut);
+  for(int32_t i = 0; i < pOut->numOfRows; ++i) {
+    if(colDataIsNull_s(pOut->columnData, i)) {
+      int8_t v = 0;
+      colDataAppendInt8(pOut->columnData, i, &v);
+      colDataSetNotNull_f(pOut->columnData->nullbitmap, i);
+    }
+  }
+  pOut->columnData->hasNull = false;
 }
 
 STagVal getJsonValue(char *json, char *key, bool *isExist) {
diff --git a/tests/system-test/2-query/json_tag.py b/tests/system-test/2-query/json_tag.py
index 7838b5c3e4..4d7aa2fd7e 100644
--- a/tests/system-test/2-query/json_tag.py
+++ b/tests/system-test/2-query/json_tag.py
@@ -109,9 +109,6 @@ class TDTestCase:
         # print("============== STEP 3 ===== query table")
         # # test error syntax
         tdSql.error("select * from jsons1 where jtag->tag1='beijing'")
-        #tdSql.error("select * from jsons1 where jtag->'location'")
-        #tdSql.error("select * from jsons1 where jtag->''")
-        #tdSql.error("select * from jsons1 where jtag->''=9")
         tdSql.error("select -> from jsons1")
         tdSql.error("select * from jsons1 where contains")
         tdSql.error("select * from jsons1 where jtag->")
@@ -341,6 +338,13 @@ class TDTestCase:
         # tdSql.checkRows(3)
         # tdSql.query("select * from jsons1 where jtag->'tag1' between 'femail' and 'beijing'")
         # tdSql.checkRows(2)
+
+        # test is true
+        tdSql.query("select * from jsons1 where jtag->'location'")
+        tdSql.checkRows(0)
+        tdSql.query("select * from jsons1 where jtag->'tag1'")
+        tdSql.checkRows(3)
+
         #
         # # test with tbname/normal column
         tdSql.query("select * from jsons1 where tbname = 'jsons1_1'")