From 729b35b6e5f40c0917116b67cc68831dfa5def05 Mon Sep 17 00:00:00 2001 From: Shengliang Guan Date: Fri, 25 Nov 2022 17:22:12 +0800 Subject: [PATCH] fix: memory leak while subscribe --- source/dnode/mnode/impl/src/mndSubscribe.c | 4 ++++ tests/parallel_test/cases.task | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/source/dnode/mnode/impl/src/mndSubscribe.c b/source/dnode/mnode/impl/src/mndSubscribe.c index 58c89d76aa..ffb46e5f1b 100644 --- a/source/dnode/mnode/impl/src/mndSubscribe.c +++ b/source/dnode/mnode/impl/src/mndSubscribe.c @@ -782,6 +782,7 @@ SUB_DECODE_OVER: return NULL; } + mTrace("subscribe:%s, decode from raw:%p, row:%p", pSub->key, pRaw, pSub); return pRow; } @@ -928,6 +929,7 @@ int32_t mndDropSubByTopic(SMnode *pMnode, STrans *pTrans, const char *topicName) action.msgType = TDMT_VND_TMQ_DELETE_SUB; if (mndTransAppendRedoAction(pTrans, &action) != 0) { taosMemoryFree(pReq); + sdbRelease(pSdb, pSub); return -1; } } @@ -936,6 +938,8 @@ int32_t mndDropSubByTopic(SMnode *pMnode, STrans *pTrans, const char *topicName) sdbRelease(pSdb, pSub); goto END; } + + sdbRelease(pSdb, pSub); } code = 0; diff --git a/tests/parallel_test/cases.task b/tests/parallel_test/cases.task index 19dcec442a..e4bd7d6c51 100644 --- a/tests/parallel_test/cases.task +++ b/tests/parallel_test/cases.task @@ -670,7 +670,7 @@ ,,,system-test,python3 test.py -f 6-cluster/vnode/4dnode1mnode_basic_replica3_vgroups.py -N 4 -M 1 ,,y,system-test,./pytest.sh python3 ./test.py -f 7-tmq/create_wrong_topic.py ,,y,system-test,./pytest.sh python3 ./test.py -f 7-tmq/dropDbR3ConflictTransaction.py -N 3 -,,,system-test,python3 ./test.py -f 7-tmq/basic5.py +,,y,system-test,./pytest.sh python3 ./test.py -f 7-tmq/basic5.py ,,,system-test,python3 ./test.py -f 7-tmq/subscribeDb.py ,,,system-test,python3 ./test.py -f 7-tmq/subscribeDb0.py ,,,system-test,python3 ./test.py -f 7-tmq/subscribeDb1.py