From 8e8230da9340d069965eb4e0141b8d9969067fb9 Mon Sep 17 00:00:00 2001 From: Alex Duan <417921451@qq.com> Date: Fri, 25 Nov 2022 17:16:16 +0800 Subject: [PATCH 1/2] fix(query): coverity fixed --- source/os/src/osTimezone.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/source/os/src/osTimezone.c b/source/os/src/osTimezone.c index 64cb007aba..4835f6d1c8 100644 --- a/source/os/src/osTimezone.c +++ b/source/os/src/osTimezone.c @@ -744,9 +744,10 @@ void taosSetSystemTimezone(const char *inTimezoneStr, char *outTimezoneStr, int8 enum TdTimezone *tsTimezone) { if (inTimezoneStr == NULL || inTimezoneStr[0] == 0) return; - char *buf = taosMemoryMalloc(strlen(inTimezoneStr) + 1); - buf[strlen(inTimezoneStr)] = 0; - for (int32_t i = 0; i < strlen(inTimezoneStr); i++) { + size_t len = strlen(inTimezoneStr); + char *buf = taosMemoryMalloc(len + 1); + memset(buf, 0, len + 1) + for (int32_t i = 0; i < len; i++) { if (inTimezoneStr[i] == ' ' || inTimezoneStr[i] == '(') { buf[i] = 0; break; From a718613944e4caa969d3a13d69eaee2a5effab79 Mon Sep 17 00:00:00 2001 From: Shengliang Guan Date: Sat, 26 Nov 2022 13:02:15 +0800 Subject: [PATCH 2/2] fix: coverity issues --- source/os/src/osTimezone.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source/os/src/osTimezone.c b/source/os/src/osTimezone.c index 4835f6d1c8..ab5600744c 100644 --- a/source/os/src/osTimezone.c +++ b/source/os/src/osTimezone.c @@ -745,8 +745,7 @@ void taosSetSystemTimezone(const char *inTimezoneStr, char *outTimezoneStr, int8 if (inTimezoneStr == NULL || inTimezoneStr[0] == 0) return; size_t len = strlen(inTimezoneStr); - char *buf = taosMemoryMalloc(len + 1); - memset(buf, 0, len + 1) + char *buf = taosMemoryCalloc(len + 1, 1); for (int32_t i = 0; i < len; i++) { if (inTimezoneStr[i] == ' ' || inTimezoneStr[i] == '(') { buf[i] = 0;