From 6f124e7b23d7f4bf2cc33aa30dfc4988e6997303 Mon Sep 17 00:00:00 2001 From: dmchen Date: Tue, 17 Dec 2024 10:36:12 +0000 Subject: [PATCH] enh/TD-29974-improve-trans-fix-case --- source/dnode/mnode/impl/src/mndTrans.c | 2 +- tests/system-test/0-others/show_transaction_detail.py | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/source/dnode/mnode/impl/src/mndTrans.c b/source/dnode/mnode/impl/src/mndTrans.c index 21a9c28830..83fad45919 100644 --- a/source/dnode/mnode/impl/src/mndTrans.c +++ b/source/dnode/mnode/impl/src/mndTrans.c @@ -2241,7 +2241,7 @@ static int32_t mndRetrieveTrans(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBl const char *killableStr = pTrans->ableToBeKilled ? "yes" : "no"; char killableVstr[10 + VARSTR_HEADER_SIZE] = {0}; - STR_WITH_MAXSIZE_TO_VARSTR(killableVstr, killableStr, 24); + STR_WITH_MAXSIZE_TO_VARSTR(killableVstr, killableStr, 10 + VARSTR_HEADER_SIZE); pColInfo = taosArrayGet(pBlock->pDataBlock, cols++); RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)killableVstr, false), pTrans, &lino, _OVER); diff --git a/tests/system-test/0-others/show_transaction_detail.py b/tests/system-test/0-others/show_transaction_detail.py index ec8ebcaef2..8a272eb76d 100644 --- a/tests/system-test/0-others/show_transaction_detail.py +++ b/tests/system-test/0-others/show_transaction_detail.py @@ -81,8 +81,13 @@ class TDTestCase: rows = tdSql.query(f"select * from information_schema.ins_transaction_details", queryTimes=1) if rows != 296: - tdLog.exit(f"restore transaction detial error, rows={rows}") + tdLog.exit(f"show transaction detial error, rows={rows}") return False + + dnode.starttaosd() + + t1.join() + t2.join() def createDbThread(self, sql, newTdSql): tdLog.info("CREATE DATABASE db2 vgroups 40 replica 3;")