From 0614bc47a871ba7db11894c09bb4ac8986663e31 Mon Sep 17 00:00:00 2001 From: Minglei Jin Date: Fri, 6 Sep 2024 14:47:50 +0800 Subject: [PATCH 1/2] fix(tsdb/file2): free fobj if appending failed --- source/dnode/vnode/src/tsdb/tsdbFSet2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source/dnode/vnode/src/tsdb/tsdbFSet2.c b/source/dnode/vnode/src/tsdb/tsdbFSet2.c index de62ce63a0..b2bc83319f 100644 --- a/source/dnode/vnode/src/tsdb/tsdbFSet2.c +++ b/source/dnode/vnode/src/tsdb/tsdbFSet2.c @@ -50,7 +50,10 @@ static int32_t tsdbSttLvlInitEx(STsdb *pTsdb, const SSttLvl *lvl1, SSttLvl **lvl } code = TARRAY2_APPEND(lvl[0]->fobjArr, fobj); - if (code) return code; + if (code) { + taosMemoryFree(fobj); + return code; + } } return 0; } From 44c19e9da8e11431b356c80a5376219eea495fd3 Mon Sep 17 00:00:00 2001 From: Hongze Cheng Date: Fri, 6 Sep 2024 15:36:57 +0800 Subject: [PATCH 2/2] fix more --- source/dnode/vnode/src/tsdb/tsdbFSet2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source/dnode/vnode/src/tsdb/tsdbFSet2.c b/source/dnode/vnode/src/tsdb/tsdbFSet2.c index b2bc83319f..f5dd2a3768 100644 --- a/source/dnode/vnode/src/tsdb/tsdbFSet2.c +++ b/source/dnode/vnode/src/tsdb/tsdbFSet2.c @@ -51,6 +51,7 @@ static int32_t tsdbSttLvlInitEx(STsdb *pTsdb, const SSttLvl *lvl1, SSttLvl **lvl code = TARRAY2_APPEND(lvl[0]->fobjArr, fobj); if (code) { + (void)tsdbSttLvlClear(lvl); taosMemoryFree(fobj); return code; }