From 297f2482036f4380be68d29c16c20613ba44fba5 Mon Sep 17 00:00:00 2001 From: Haojun Liao Date: Fri, 14 Feb 2025 14:34:08 +0800 Subject: [PATCH 1/2] fix(stream): access value after null ptr check. --- source/libs/stream/src/streamMeta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/libs/stream/src/streamMeta.c b/source/libs/stream/src/streamMeta.c index 9a2eeb9311..ddd0201460 100644 --- a/source/libs/stream/src/streamMeta.c +++ b/source/libs/stream/src/streamMeta.c @@ -572,11 +572,11 @@ void streamMetaClear(SStreamMeta* pMeta) { } void streamMetaClose(SStreamMeta* pMeta) { - stDebug("vgId:%d start to close stream meta", pMeta->vgId); if (pMeta == NULL) { return; } + stDebug("vgId:%d start to close stream meta", pMeta->vgId); int32_t code = taosRemoveRef(streamMetaRefPool, pMeta->rid); if (code) { stError("vgId:%d failed to remove meta ref:%" PRId64 ", code:%s", pMeta->vgId, pMeta->rid, tstrerror(code)); From 57a2471cc66b6f041dea4aab35c7804e62b602dc Mon Sep 17 00:00:00 2001 From: Haojun Liao Date: Sat, 15 Feb 2025 00:03:33 +0800 Subject: [PATCH 2/2] fix(stream): add missing release --- source/dnode/vnode/src/tqCommon/tqCommon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source/dnode/vnode/src/tqCommon/tqCommon.c b/source/dnode/vnode/src/tqCommon/tqCommon.c index bcf60f5c32..77632d328e 100644 --- a/source/dnode/vnode/src/tqCommon/tqCommon.c +++ b/source/dnode/vnode/src/tqCommon/tqCommon.c @@ -1217,6 +1217,7 @@ int32_t tqStreamTaskProcessTaskResumeReq(void* handle, int64_t sversion, char* m streamMetaReleaseTask(pMeta, pHTask); } + streamMetaReleaseTask(pMeta, pTask); return TSDB_CODE_SUCCESS; }