From 574998f02835372490b6d5b9cfeec555a34ebb78 Mon Sep 17 00:00:00 2001
From: wangmm0220 <wangmm0220@gmail.com>
Date: Tue, 22 Oct 2024 17:50:26 +0800
Subject: [PATCH] enh:[TD-32166]remove useless code in sml

---
 source/client/src/clientSml.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/source/client/src/clientSml.c b/source/client/src/clientSml.c
index 9f9671f340..c17ff1413e 100644
--- a/source/client/src/clientSml.c
+++ b/source/client/src/clientSml.c
@@ -197,7 +197,13 @@ void smlBuildTsKv(SSmlKv *kv, int64_t ts) {
 }
 
 static void smlDestroySTableMeta(void *para) {
+  if (para == NULL) {
+    return;
+  }
   SSmlSTableMeta *meta = *(SSmlSTableMeta **)para;
+  if (meta == NULL) {
+    return;
+  }
   taosHashCleanup(meta->tagHash);
   taosHashCleanup(meta->colHash);
   taosArrayDestroy(meta->tags);
@@ -252,7 +258,7 @@ int32_t smlBuildSuperTableInfo(SSmlHandle *info, SSmlLineInfo *currElement, SSml
   return code;
 
 END:
-  smlDestroySTableMeta(*sMeta);
+  smlDestroySTableMeta(sMeta);
   taosMemoryFreeClear(pTableMeta);
   return code;
 }
@@ -587,7 +593,7 @@ int32_t smlBuildSTableMeta(bool isDataFormat, SSmlSTableMeta **sMeta) {
   return TSDB_CODE_SUCCESS;
 
 END:
-  smlDestroySTableMeta(meta);
+  smlDestroySTableMeta(&meta);
   return TSDB_CODE_OUT_OF_MEMORY;
 }
 
@@ -1400,7 +1406,7 @@ static int32_t smlParseLineBottom(SSmlHandle *info) {
       SML_CHECK_CODE(smlBuildSTableMeta(info->dataFormat, &meta));
       code = taosHashPut(info->superTables, elements->measure, elements->measureLen, &meta, POINTER_BYTES);
       if (code != TSDB_CODE_SUCCESS) {
-        smlDestroySTableMeta(meta);
+        smlDestroySTableMeta(&meta);
         uError("SML:0x%" PRIx64 " put measuer to hash failed", info->id);
         goto END;
       }