diff --git a/source/dnode/mnode/impl/src/mndMain.c b/source/dnode/mnode/impl/src/mndMain.c index 4d91b17252..51c1d90d69 100644 --- a/source/dnode/mnode/impl/src/mndMain.c +++ b/source/dnode/mnode/impl/src/mndMain.c @@ -911,11 +911,8 @@ _OVER: int32_t contLen = tSerializeSEpSet(NULL, 0, &epSet); pMsg->info.rsp = rpcMallocCont(contLen); if (pMsg->info.rsp != NULL) { - code = tSerializeSEpSet(pMsg->info.rsp, contLen, &epSet); - if (code < 0) { - rpcFreeCont(pMsg->info.rsp); - pMsg->info.rsp = NULL; - TAOS_RETURN(code); + if (tSerializeSEpSet(pMsg->info.rsp, contLen, &epSet) < 0) { + mError("failed to serialize ep set"); } pMsg->info.hasEpSet = 1; pMsg->info.rspLen = contLen; diff --git a/source/dnode/mnode/impl/src/mndSnode.c b/source/dnode/mnode/impl/src/mndSnode.c index 3bfc7a7eea..2fb3d377c4 100644 --- a/source/dnode/mnode/impl/src/mndSnode.c +++ b/source/dnode/mnode/impl/src/mndSnode.c @@ -225,8 +225,7 @@ static int32_t mndSetCreateSnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, S } code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, &createReq); if (code < 0) { - taosMemoryFree(pReq); - TAOS_RETURN(code); + mError("snode:%d, failed to serialize create drop snode request since %s", createReq.dnodeId, terrstr()); } STransAction action = {0}; @@ -257,8 +256,7 @@ static int32_t mndSetCreateSnodeUndoActions(STrans *pTrans, SDnodeObj *pDnode, S } code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, &dropReq); if (code < 0) { - taosMemoryFree(pReq); - TAOS_RETURN(code); + mError("snode:%d, failed to serialize create drop snode request since %s", dropReq.dnodeId, terrstr()); } STransAction action = {0}; @@ -393,8 +391,7 @@ static int32_t mndSetDropSnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SSn } code = tSerializeSCreateDropMQSNodeReq(pReq, contLen, &dropReq); if (code < 0) { - taosMemoryFree(pReq); - TAOS_RETURN(code); + mError("snode:%d, failed to serialize create drop snode request since %s", dropReq.dnodeId, terrstr()); } STransAction action = {0};