From 5555371fbc390d713ba0118873714ccbcd01380b Mon Sep 17 00:00:00 2001
From: wangmm0220 <wangmm0220@gmail.com>
Date: Fri, 22 Sep 2023 10:04:53 +0800
Subject: [PATCH] fix:memory leak

---
 source/dnode/vnode/src/tq/tqOffsetSnapshot.c  | 1 +
 source/libs/stream/src/streamBackendRocksdb.c | 1 +
 source/libs/stream/src/streamSnapshot.c       | 5 +++++
 3 files changed, 7 insertions(+)

diff --git a/source/dnode/vnode/src/tq/tqOffsetSnapshot.c b/source/dnode/vnode/src/tq/tqOffsetSnapshot.c
index 85d4dc6c0f..8a7f672e5d 100644
--- a/source/dnode/vnode/src/tq/tqOffsetSnapshot.c
+++ b/source/dnode/vnode/src/tq/tqOffsetSnapshot.c
@@ -85,6 +85,7 @@ int32_t tqOffsetSnapRead(STqOffsetReader* pReader, uint8_t** ppData) {
   *ppData = (uint8_t*)buf;
 
   pReader->readEnd = 1;
+  taosCloseFile(&pFile);
   return 0;
 }
 
diff --git a/source/libs/stream/src/streamBackendRocksdb.c b/source/libs/stream/src/streamBackendRocksdb.c
index 19f4ebbeea..0cc8bfb6fe 100644
--- a/source/libs/stream/src/streamBackendRocksdb.c
+++ b/source/libs/stream/src/streamBackendRocksdb.c
@@ -905,6 +905,7 @@ int32_t streamBackendTriggerChkp(void* arg, char* dst) {
   }
 
 _ERROR:
+  taosMemoryFree(ppCf);
   taosReleaseRef(streamBackendId, backendRid);
   taosArrayDestroy(refs);
   return code;
diff --git a/source/libs/stream/src/streamSnapshot.c b/source/libs/stream/src/streamSnapshot.c
index 8a4500dd86..1e27aec03b 100644
--- a/source/libs/stream/src/streamSnapshot.c
+++ b/source/libs/stream/src/streamSnapshot.c
@@ -341,11 +341,15 @@ int32_t streamSnapRead(SStreamSnapReader* pReader, uint8_t** ppData, int64_t* si
   qDebug("%s start to read file %s, current offset:%" PRId64 ", size:%" PRId64 ", file no.%d", STREAM_STATE_TRANSFER,
          item->name, (int64_t)pHandle->offset, item->size, pHandle->currFileIdx);
   uint8_t* buf = taosMemoryCalloc(1, sizeof(SStreamSnapBlockHdr) + kBlockSize);
+  if(buf == NULL){
+    return TSDB_CODE_OUT_OF_MEMORY;
+  }
   int64_t  nread = taosPReadFile(pHandle->fd, buf + sizeof(SStreamSnapBlockHdr), kBlockSize, pHandle->offset);
   if (nread == -1) {
     code = TAOS_SYSTEM_ERROR(terrno);
     qError("%s snap failed to read snap, file name:%s, type:%d,reason:%s", STREAM_STATE_TRANSFER, item->name,
            item->type, tstrerror(code));
+    taosMemoryFree(buf);
     return -1;
   } else if (nread > 0 && nread <= kBlockSize) {
     // left bytes less than kBlockSize
@@ -368,6 +372,7 @@ int32_t streamSnapRead(SStreamSnapReader* pReader, uint8_t** ppData, int64_t* si
       // finish
       *ppData = NULL;
       *size = 0;
+      taosMemoryFree(buf);
       return 0;
     }
     item = taosArrayGet(pHandle->pFileList, pHandle->currFileIdx);