From 549ee9f2e027eb3b2a65d9c9301a8658932a7ac8 Mon Sep 17 00:00:00 2001
From: xsren <285808407@qq.com>
Date: Fri, 1 Sep 2023 16:37:51 +0800
Subject: [PATCH] atomic rename file on windows

---
 source/os/CMakeLists.txt |  1 +
 source/os/src/osFile.c   | 30 ++++++++++++++++++++++++++----
 2 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/source/os/CMakeLists.txt b/source/os/CMakeLists.txt
index 46e28b529d..14bcda857f 100644
--- a/source/os/CMakeLists.txt
+++ b/source/os/CMakeLists.txt
@@ -40,6 +40,7 @@ target_link_libraries(
     os
     PUBLIC pthread
     PUBLIC zlibstatic
+    PUBLIC KtmW32
 )
 if(TD_WINDOWS)
     target_link_libraries(
diff --git a/source/os/src/osFile.c b/source/os/src/osFile.c
index ede1f1fb0e..e014470fed 100644
--- a/source/os/src/osFile.c
+++ b/source/os/src/osFile.c
@@ -19,6 +19,8 @@
 
 #ifdef WINDOWS
 #include <io.h>
+#include <WinBase.h>
+#include <ktmw32.h>
 #define F_OK 0
 #define W_OK 2
 #define R_OK 4
@@ -175,12 +177,32 @@ int32_t taosRemoveFile(const char *path) { return remove(path); }
 
 int32_t taosRenameFile(const char *oldName, const char *newName) {
 #ifdef WINDOWS
-  bool code = MoveFileEx(oldName, newName, MOVEFILE_REPLACE_EXISTING | MOVEFILE_COPY_ALLOWED);
-  if (!code) {
-    printf("failed to rename file %s to %s, reason:%s\n", oldName, newName, strerror(errno));
+  bool finished = false;
+
+  HANDLE transactionHandle = CreateTransaction(NULL, NULL, 0, 0, 0, INFINITE, NULL);
+  if (transactionHandle == INVALID_HANDLE_VALUE) {
+    printf("failed to rename file %s to %s, reason: CreateTransaction failed.\n", oldName, newName);
+    return -1;
   }
 
-  return code ? 0 : -1;
+  BOOL result = MoveFileTransacted(oldName, newName, NULL, NULL, MOVEFILE_REPLACE_EXISTING, transactionHandle);
+
+  if (result) {
+    finished = CommitTransaction(transactionHandle);
+    if (!finished) {
+      DWORD error = GetLastError();
+      printf("failed to rename file %s to %s, reason: CommitTransaction errcode %d.\n", oldName, newName, error);
+    }
+  } else {
+    RollbackTransaction(transactionHandle);
+    DWORD error = GetLastError();
+    finished = false;
+    printf("failed to rename file %s to %s, reason: MoveFileTransacted errcode %d.\n", oldName, newName, error);
+  }
+
+  CloseHandle(transactionHandle);
+
+  return finished ? 0 : -1;
 #else
   int32_t code = rename(oldName, newName);
   if (code < 0) {