From 50482c7e41173c5c9e31bb9e2b803161f2892f40 Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Tue, 12 Nov 2024 18:10:30 +0800
Subject: [PATCH] fix/TD-32838-add-writer-lock-fix-review

---
 source/libs/sync/src/syncSnapshot.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/source/libs/sync/src/syncSnapshot.c b/source/libs/sync/src/syncSnapshot.c
index 4e7652f76e..a89667ad3d 100644
--- a/source/libs/sync/src/syncSnapshot.c
+++ b/source/libs/sync/src/syncSnapshot.c
@@ -429,7 +429,12 @@ int32_t snapshotReceiverCreate(SSyncNode *pSyncNode, SRaftId fromId, SSyncSnapsh
   pReceiver->startTime = 0;
   pReceiver->ack = SYNC_SNAPSHOT_SEQ_BEGIN;
   pReceiver->pWriter = NULL;
-  (void)taosThreadMutexInit(&pReceiver->writerMutex, NULL);
+  code = taosThreadMutexInit(&pReceiver->writerMutex, NULL);
+  if (code != 0) {
+    taosMemoryFree(pReceiver);
+    pReceiver = NULL;
+    TAOS_RETURN(code);
+  }
   pReceiver->pSyncNode = pSyncNode;
   pReceiver->fromId = fromId;
   pReceiver->term = raftStoreGetTerm(pSyncNode);
@@ -441,7 +446,10 @@ int32_t snapshotReceiverCreate(SSyncNode *pSyncNode, SRaftId fromId, SSyncSnapsh
   SSyncSnapBuffer *pRcvBuf = NULL;
   code = syncSnapBufferCreate(&pRcvBuf);
   if (pRcvBuf == NULL) {
-    taosThreadMutexDestroy(&pReceiver->writerMutex);
+    int32_t ret = taosThreadMutexDestroy(&pReceiver->writerMutex);
+    if (ret != 0) {
+      sError("failed to destroy mutex since %s", tstrerror(ret));
+    }
     taosMemoryFree(pReceiver);
     pReceiver = NULL;
     TAOS_RETURN(code);