From 6895bb121f1f7cb9f88319af99cb2998145e2c99 Mon Sep 17 00:00:00 2001 From: Shungang Li Date: Wed, 8 May 2024 10:48:05 +0800 Subject: [PATCH] fix: handle memleak in vnodeSnapWriterOpen, add log for abort_edit --- source/dnode/vnode/src/tsdb/tsdbFS2.c | 1 + source/dnode/vnode/src/vnd/vnodeSnapshot.c | 1 + 2 files changed, 2 insertions(+) diff --git a/source/dnode/vnode/src/tsdb/tsdbFS2.c b/source/dnode/vnode/src/tsdb/tsdbFS2.c index 7741a1b096..3ca26621a1 100644 --- a/source/dnode/vnode/src/tsdb/tsdbFS2.c +++ b/source/dnode/vnode/src/tsdb/tsdbFS2.c @@ -327,6 +327,7 @@ static int32_t abort_edit(STFileSystem *fs) { } else if (fs->etype == TSDB_FEDIT_MERGE) { current_fname(fs->tsdb, fname, TSDB_FCURRENT_M); } else { + tsdbError("vgId:%d %s failed since invalid etype:%d", TD_VID(fs->tsdb->pVnode), __func__, fs->etype); ASSERT(0); } diff --git a/source/dnode/vnode/src/vnd/vnodeSnapshot.c b/source/dnode/vnode/src/vnd/vnodeSnapshot.c index b4c8a26f5c..ea742108aa 100644 --- a/source/dnode/vnode/src/vnd/vnodeSnapshot.c +++ b/source/dnode/vnode/src/vnd/vnodeSnapshot.c @@ -666,6 +666,7 @@ int32_t vnodeSnapWriterOpen(SVnode *pVnode, SSnapshotParam *pParam, SVSnapWriter _err: vError("vgId:%d, vnode snapshot writer open failed since %s", TD_VID(pVnode), tstrerror(code)); + if (pWriter) taosMemoryFreeClear(pWriter); *ppWriter = NULL; return code; }