From 44866b7b124dc969ab3ecc523b77f7b9b2cc6ae4 Mon Sep 17 00:00:00 2001
From: Hongze Cheng <hzcheng@taosdata.com>
Date: Wed, 22 Nov 2023 20:35:18 +0800
Subject: [PATCH] fix: possible race condition coredump

---
 source/dnode/vnode/src/tsdb/tsdbFS2.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/source/dnode/vnode/src/tsdb/tsdbFS2.c b/source/dnode/vnode/src/tsdb/tsdbFS2.c
index dd49a3319c..c9ecff8890 100644
--- a/source/dnode/vnode/src/tsdb/tsdbFS2.c
+++ b/source/dnode/vnode/src/tsdb/tsdbFS2.c
@@ -1186,11 +1186,6 @@ const char *gFSBgTaskName[] = {NULL, "MERGE", "RETENTION", "COMPACT"};
 static int32_t tsdbFSRunBgTask(void *arg) {
   STFSBgTask   *task = (STFSBgTask *)arg;
   STFileSystem *fs = task->fs;
-  STFileSet    *fset;
-
-  tsdbFSGetFSet(fs, task->fid, &fset);
-
-  ASSERT(fset != NULL && fset->bgTaskRunning == task);
 
   task->launchTime = taosGetTimestampMs();
   task->run(task->arg);
@@ -1203,6 +1198,10 @@ static int32_t tsdbFSRunBgTask(void *arg) {
 
   taosThreadMutexLock(&fs->tsdb->mutex);
 
+  STFileSet *fset = NULL;
+  tsdbFSGetFSet(fs, task->fid, &fset);
+  ASSERT(fset != NULL && fset->bgTaskRunning == task);
+
   // free last
   tsdbDoDoneBgTask(fs, task);
   fset->bgTaskRunning = NULL;