From 43c056fb617dd1dfbb7276491fe63979a57d3db4 Mon Sep 17 00:00:00 2001
From: dapan1121 <wpan@taosdata.com>
Date: Thu, 17 Aug 2023 16:01:38 +0800
Subject: [PATCH] fix: node clone and mac compile issues

---
 source/libs/executor/src/groupcacheoperator.c | 6 +++---
 source/libs/executor/src/hashjoinoperator.c   | 2 +-
 source/libs/planner/src/planOptimizer.c       | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/source/libs/executor/src/groupcacheoperator.c b/source/libs/executor/src/groupcacheoperator.c
index ffb3a913d3..ff771ccc8c 100755
--- a/source/libs/executor/src/groupcacheoperator.c
+++ b/source/libs/executor/src/groupcacheoperator.c
@@ -167,7 +167,7 @@ static void destroySGcBlkCacheInfo(SGcBlkCacheInfo* pBlkCache) {
   taosHashCleanup(pBlkCache->pDirtyBlk);
 
   void* p = NULL;
-  while (p = taosHashIterate(pBlkCache->pReadBlk, p)) {
+  while (NULL != (p = taosHashIterate(pBlkCache->pReadBlk, p))) {
     blockDataDeepCleanup(*(SSDataBlock**)p);
     freeGcBlockInList(p);
   }
@@ -892,14 +892,14 @@ static int32_t handleDownstreamFetchDone(struct SOperatorInfo* pOperator, SGcSes
   if (pGCache->batchFetch) {
     SHashObj* pGrpHash = pGCache->globalGrp ? pGCache->pGrpHash : pCtx->pGrpHash;
     SGroupCacheData* pGroup = NULL;
-    while (pGroup = taosHashIterate(pGrpHash, pGroup)) {
+    while (NULL != (pGroup = taosHashIterate(pGrpHash, pGroup))) {
       handleGroupFetchDone(pGroup);
     }
   } else {
     int32_t uidNum = 0;
     SGcVgroupCtx* pVgCtx = NULL;
     int32_t iter = 0;
-    while (pVgCtx = tSimpleHashIterate(pCtx->pVgTbHash, pVgCtx, &iter)) {
+    while (NULL != (pVgCtx = tSimpleHashIterate(pCtx->pVgTbHash, pVgCtx, &iter))) {
       uidNum = taosArrayGetSize(pVgCtx->pTbList);
       for (int32_t i = 0; i < uidNum; ++i) {
         SGcNewGroupInfo* pNew = taosArrayGet(pVgCtx->pTbList, i);
diff --git a/source/libs/executor/src/hashjoinoperator.c b/source/libs/executor/src/hashjoinoperator.c
index c26ad2dddc..d57f9f9f90 100755
--- a/source/libs/executor/src/hashjoinoperator.c
+++ b/source/libs/executor/src/hashjoinoperator.c
@@ -42,7 +42,7 @@ static int64_t getRowsNumOfKeyHash(SSHashObj* pHash) {
   int32_t iter = 0;
   int64_t rowsNum = 0;
   
-  while (pGroup = tSimpleHashIterate(pHash, pGroup, &iter)) {
+  while (NULL != (pGroup = tSimpleHashIterate(pHash, pGroup, &iter))) {
     int32_t* pKey = tSimpleHashGetKey(pGroup, NULL);
     int64_t rows = getSingleKeyRowsNum(pGroup->rows);
     qTrace("build_key:%d, rows:%" PRId64, *pKey, rows);
diff --git a/source/libs/planner/src/planOptimizer.c b/source/libs/planner/src/planOptimizer.c
index 285b60b852..83c82cb07a 100644
--- a/source/libs/planner/src/planOptimizer.c
+++ b/source/libs/planner/src/planOptimizer.c
@@ -941,7 +941,7 @@ static int32_t pushDownCondOptAppendFilterCol(SOptimizeContext* pCxt, SJoinLogic
         }
       }
       if (!found) {
-        nodesListStrictAppend(pJoin->node.pTargets, pNode);
+        nodesListStrictAppend(pJoin->node.pTargets, nodesCloneNode(pNode));
       }
     }
   }