From 40a28a6e4bb57bdebe3a6b8228fbdbf944d2a668 Mon Sep 17 00:00:00 2001 From: slzhou Date: Wed, 22 Nov 2023 08:47:35 +0800 Subject: [PATCH] fix: refactor dependency between community and enterprise --- source/libs/parser/inc/parTranslater.h | 3 +-- source/libs/parser/src/parTranslater.c | 15 +++++++-------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/source/libs/parser/inc/parTranslater.h b/source/libs/parser/inc/parTranslater.h index bec4e07e1c..0fe99e04ab 100644 --- a/source/libs/parser/inc/parTranslater.h +++ b/source/libs/parser/inc/parTranslater.h @@ -46,8 +46,7 @@ typedef struct STranslateContext { SNode* pPostRoot; } STranslateContext; -EDealRes biRewriteToTbnameFuncAndTranslate(STranslateContext* pCxt, SColumnNode** ppCol); -EDealRes translateFunction(STranslateContext* pCxt, SFunctionNode** pFunc); +bool biRewriteToTbnameFunc(STranslateContext* pCxt, SNode** ppNode); int32_t biRewriteSelectStar(STranslateContext* pCxt, SSelectStmt* pSelect); int32_t findTable(STranslateContext* pCxt, const char* pTableAlias, STableNode** pOutput); int32_t getTargetMetaImpl(SParseContext* pParCxt, SParseMetaCache* pMetaCache, const SName* pName, STableMeta** pMeta, bool couldBeView); diff --git a/source/libs/parser/src/parTranslater.c b/source/libs/parser/src/parTranslater.c index b868d39cfd..729a0d8855 100644 --- a/source/libs/parser/src/parTranslater.c +++ b/source/libs/parser/src/parTranslater.c @@ -263,6 +263,7 @@ static const SSysTableShowAdapter sysTableShowAdapter[] = { static int32_t translateSubquery(STranslateContext* pCxt, SNode* pNode); static int32_t translateQuery(STranslateContext* pCxt, SNode* pNode); static EDealRes translateValue(STranslateContext* pCxt, SValueNode* pVal); +static EDealRes translateFunction(STranslateContext* pCxt, SFunctionNode** pFunc); static int32_t createSimpleSelectStmtFromProjList(const char* pDb, const char* pTable, SNodeList* pProjectionList, SSelectStmt** pStmt); static int32_t createLastTsSelectStmt(char* pDb, char* pTable, STableMeta* pMeta, SNode** pQuery); @@ -1092,8 +1093,8 @@ static EDealRes translateColumnUseAlias(STranslateContext* pCxt, SColumnNode** p } #ifndef TD_ENTERPRISE -EDealRes biRewriteToTbnameFuncAndTranslate(STranslateContext* pCxt, SColumnNode** ppCol) { - return DEAL_RES_CONTINUE; +bool biRewriteToTbnameFunc(STranslateContext* pCxt, SNode** ppNode) { + return false; } #endif @@ -1109,11 +1110,9 @@ static EDealRes translateColumn(STranslateContext* pCxt, SColumnNode** pCol) { } if (pCxt->pParseCxt->biMode) { - if ((strcasecmp((*pCol)->colName, "tbname") == 0) && - ((SSelectStmt*)pCxt->pCurrStmt)->pFromTable && - QUERY_NODE_REAL_TABLE == nodeType(((SSelectStmt*)pCxt->pCurrStmt)->pFromTable)) { - EDealRes res = biRewriteToTbnameFuncAndTranslate(pCxt, pCol); - return res; + SNode** ppNode = (SNode**)pCol; + if (biRewriteToTbnameFunc(pCxt, ppNode)) { + translateFunction(pCxt, (SFunctionNode**)ppNode); } } @@ -2219,7 +2218,7 @@ static int32_t translateFunctionImpl(STranslateContext* pCxt, SFunctionNode** pF return translateNormalFunction(pCxt, (SNode**)pFunc); } -EDealRes translateFunction(STranslateContext* pCxt, SFunctionNode** pFunc) { +static EDealRes translateFunction(STranslateContext* pCxt, SFunctionNode** pFunc) { SNode* pParam = NULL; FOREACH(pParam, (*pFunc)->pParameterList) { if (isMultiResFunc(pParam)) {