xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore: logic optimization

This commit is contained in:
kailixu 2025-02-09 09:31:41 +08:00
parent f9dc305e35
commit 3edb8ae41c
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/util/src/tlog.c
View File

@ -393,13 +393,15 @@ static void taosKeepOldLog(char *oldName) {
snprintf(compressFileName, PATH_MAX + 20, "%s.gz", oldName); snprintf(compressFileName, PATH_MAX + 20, "%s.gz", oldName);
TAOS_CHECK_GOTO(taosCompressFile(oldName, compressFileName), &lino, _exit1); TAOS_CHECK_GOTO(taosCompressFile(oldName, compressFileName), &lino, _exit1);
TAOS_CHECK_GOTO(taosRemoveFile(oldName), &lino, _exit1); TAOS_CHECK_GOTO(taosRemoveFile(oldName), &lino, _exit1);
_exit1:
TAOS_UNUSED(taosUnLockFile(oldFile));
_exit2:
TAOS_UNUSED(taosCloseFile(&oldFile));
} else {
code = terrno;
} }
_exit1: if (code != 0 && tsLogEmbedded == 1) { // print error messages only in embedded log mode
TAOS_UNUSED(taosUnLockFile(oldFile)); // avoid using uWarn or uError, as they may open a new log file and potentially cause a deadlock.
_exit2:
TAOS_UNUSED(taosCloseFile(&oldFile));
if (code != 0 && tsLogEmbedded == 1) { // only print error message in embedded log mode
// don't use uWarn or uError, because it may open new log file and cause dead lock
fprintf(stderr, "failed at line %d to keep old log file:%s, reason:%s\n", lino, oldName, tstrerror(code)); fprintf(stderr, "failed at line %d to keep old log file:%s, reason:%s\n", lino, oldName, tstrerror(code));
} }
} }