From 523994d93b135bacb8d1703aaef0f7375b5ef7c1 Mon Sep 17 00:00:00 2001
From: kailixu <klxu@taosdata.com>
Date: Tue, 29 Aug 2023 15:15:07 +0800
Subject: [PATCH 1/2] enh: allow altering options to the same value

---
 source/dnode/mnode/impl/src/mndDb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/source/dnode/mnode/impl/src/mndDb.c b/source/dnode/mnode/impl/src/mndDb.c
index c58df5c88c..69bb267bc5 100644
--- a/source/dnode/mnode/impl/src/mndDb.c
+++ b/source/dnode/mnode/impl/src/mndDb.c
@@ -964,7 +964,10 @@ static int32_t mndProcessAlterDbReq(SRpcMsg *pReq) {
   }
 
   code = mndSetDbCfgFromAlterDbReq(&dbObj, &alterReq);
-  if (code != 0) goto _OVER;
+  if (code != 0) {
+    if (code == TSDB_CODE_MND_DB_OPTION_UNCHANGED) code = 0;
+    goto _OVER;
+  }
 
   code = mndCheckInChangeDbCfg(pMnode, &dbObj.cfg);
   if (code != 0) goto _OVER;

From 1e4e2549a44979adaaaf03fa81f35b79314a3380 Mon Sep 17 00:00:00 2001
From: kailixu <klxu@taosdata.com>
Date: Tue, 29 Aug 2023 19:53:59 +0800
Subject: [PATCH 2/2] chore: add test cases

---
 .../parser/alter__for_community_version.sim   |  4 +--
 tests/system-test/1-insert/alter_database.py  | 29 +++++++++++++++++--
 2 files changed, 29 insertions(+), 4 deletions(-)

diff --git a/tests/script/tsim/parser/alter__for_community_version.sim b/tests/script/tsim/parser/alter__for_community_version.sim
index b902daa2dd..48fb2f8246 100644
--- a/tests/script/tsim/parser/alter__for_community_version.sim
+++ b/tests/script/tsim/parser/alter__for_community_version.sim
@@ -35,7 +35,7 @@ sql_error alter database $db keep 20.0,20.0,20.0
 sql_error alter database $db keep 0,0,0
 sql_error alter database $db keep 3
 sql_error alter database $db keep -1,-1,-1
-sql_error alter database $db keep 20,20
+sql alter database $db keep 20,20
 sql_error alter database $db keep 9,9,9
 sql_error alter database $db keep 20,20,19
 sql_error alter database $db keep 20,19,20
@@ -44,7 +44,7 @@ sql_error alter database $db keep 20,19,18
 sql_error alter database $db keep 20,20,20,20
 sql_error alter database $db keep 365001,365001,365001
 sql_error alter database $db keep 365001
-sql_error alter database $db keep 20
+sql alter database $db keep 20
 sql select * from information_schema.ins_databases
 if $rows != 3 then
   return -1
diff --git a/tests/system-test/1-insert/alter_database.py b/tests/system-test/1-insert/alter_database.py
index 1fca294a47..8de43b8ee8 100644
--- a/tests/system-test/1-insert/alter_database.py
+++ b/tests/system-test/1-insert/alter_database.py
@@ -18,7 +18,7 @@ class TDTestCase:
         tdSql.init(conn.cursor(), logSql)
         self.buffer_boundary = [3, 4097, 8193, 12289, 16384]
         self.buffer_error = [self.buffer_boundary[0] -
-                             1, self.buffer_boundary[-1]+1, 256]
+                             1, self.buffer_boundary[-1]+1]
         # pages_boundary >= 64
         self.pages_boundary = [64, 128, 512]
         self.pages_error = [self.pages_boundary[0]-1]
@@ -47,15 +47,40 @@ class TDTestCase:
         tdSql.execute('create database db')
         tdSql.query(
             'select * from information_schema.ins_databases where name = "db"')
-        self.pages_error.append(tdSql.queryResult[0][10])
+        # self.pages_error.append(tdSql.queryResult[0][10])
         for pages in self.pages_error:
             tdSql.error(f'alter database db pages {pages}')
         tdSql.execute('drop database db')
 
+    def alter_same_options(self):
+        tdSql.execute('drop database if exists db')
+        tdSql.execute('create database db')
+        tdSql.query('select * from information_schema.ins_databases where name = "db"')
+        
+        db_options_items = ["replica","keep","buffer","pages","minrows","cachemodel","cachesize","wal_level","wal_fsync_period",
+                      "wal_retention_period","wal_retention_size","stt_trigger"]
+        db_options_result_idx = [4,7,8,10,11,18,19,20,21,22,23,24]
+        
+        self.option_result = []
+        for idx in db_options_result_idx:
+            self.option_result.append(tdSql.queryResult[0][idx])
+        
+        index = 0
+        for option in db_options_items:
+            if option == "cachemodel":
+                option_sql = "alter database db %s '%s'" % (option, self.option_result[index] )
+            else:
+                option_sql = "alter database db %s %s" % (option, self.option_result[index] )
+            tdLog.debug(option_sql)
+            tdSql.query(option_sql)
+            index += 1
+        tdSql.execute('drop database db')
+        
     def run(self):
         
         self.alter_buffer()
         self.alter_pages()
+        self.alter_same_options()
 
     def stop(self):
         tdSql.close()