From 246a375cc278458d5a5b6762e976aa46f4f9d984 Mon Sep 17 00:00:00 2001 From: dmchen Date: Thu, 21 Nov 2024 18:28:37 +0800 Subject: [PATCH] ehn/vnode-open-log-fix-review --- source/libs/sync/src/syncAppendEntries.c | 8 ++++---- source/libs/sync/src/syncReplication.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/source/libs/sync/src/syncAppendEntries.c b/source/libs/sync/src/syncAppendEntries.c index 42913011d1..9fc39ec463 100644 --- a/source/libs/sync/src/syncAppendEntries.c +++ b/source/libs/sync/src/syncAppendEntries.c @@ -104,10 +104,10 @@ int32_t syncNodeOnAppendEntries(SSyncNode* ths, const SRpcMsg* pRpcMsg) { goto _IGNORE; } - int32_t nRef = atomic_fetch_add_32(&ths->recvCount, 1); - if (nRef < 0) { - sError("vgId:%d, recv count is %d", ths->vgId, nRef); - } + int32_t nRef = atomic_add_fetch_32(&ths->recvCount, 1); + if (nRef <= 0) { + sError("vgId:%d, recv count is %d", ths->vgId, nRef); + } int32_t code = syncBuildAppendEntriesReply(&rpcRsp, ths->vgId); if (code != 0) { diff --git a/source/libs/sync/src/syncReplication.c b/source/libs/sync/src/syncReplication.c index 8c7bdebc9e..aa0493dadb 100644 --- a/source/libs/sync/src/syncReplication.c +++ b/source/libs/sync/src/syncReplication.c @@ -90,16 +90,16 @@ int32_t syncNodeSendAppendEntries(SSyncNode* pSyncNode, const SRaftId* destRaftI int32_t nRef = 0; if (pSyncNode != NULL) { - nRef = atomic_fetch_add_32(&pSyncNode->sendCount, 1); - if (nRef < 0) { + nRef = atomic_add_fetch_32(&pSyncNode->sendCount, 1); + if (nRef <= 0) { sError("vgId:%d, send count is %d", pSyncNode->vgId, nRef); } } SSyncLogReplMgr* mgr = syncNodeGetLogReplMgr(pSyncNode, (SRaftId*)destRaftId); if (mgr != NULL) { - nRef = atomic_fetch_add_32(&mgr->sendCount, 1); - if (nRef < 0) { + nRef = atomic_add_fetch_32(&mgr->sendCount, 1); + if (nRef <= 0) { sError("vgId:%d, send count is %d", pSyncNode->vgId, nRef); } }