xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fixed a few bugs in state transition checks

This commit is contained in:
Steven Li 2020-05-24 00:47:58 -07:00
parent a72218378f
commit 2416465519
1 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/pytest/crash_gen.py
View File

@ -480,7 +480,7 @@ class DbState():
def getTasksAtState(self): def getTasksAtState(self):
tasks = [] tasks = []
tasks.append(ReadFixedDataTask(self)) # always tasks.append(ReadFixedDataTask(self)) # always for everybody
if ( self._state == self.STATE_EMPTY ): if ( self._state == self.STATE_EMPTY ):
tasks.append(CreateDbTask(self)) tasks.append(CreateDbTask(self))
tasks.append(CreateFixedTableTask(self)) tasks.append(CreateFixedTableTask(self))
@ -535,11 +535,15 @@ class DbState():
self._state = self.STATE_TABLE_ONLY self._state = self.STATE_TABLE_ONLY
else: else:
self._state = self.STATE_HAS_DATA self._state = self.STATE_HAS_DATA
else: # no success in dropping db tasks, no success in create fixed table, not acceptable # What about AddFixedData?
raise RuntimeError("Unexpected no-success scenario") elif ( self.hasSuccess(tasks, AddFixedDataTask) ):
self._state = self.STATE_HAS_DATA
else: # no success in dropping db tasks, no success in create fixed table? read data should also fail
# raise RuntimeError("Unexpected no-success scenario") # We might just landed all failure tasks,
self._state = self.STATE_DB_ONLY # no change
elif ( self._state == self.STATE_TABLE_ONLY ): elif ( self._state == self.STATE_TABLE_ONLY ):
if ( self.hasSuccess(tasks, DropFixedTableTask) ): if ( self.hasSuccess(tasks, DropFixedTableTask) ): # we are able to drop the table
self.assertAtMostOneSuccess(tasks, DropFixedTableTask) self.assertAtMostOneSuccess(tasks, DropFixedTableTask)
self._state = self.STATE_DB_ONLY self._state = self.STATE_DB_ONLY
elif ( self.hasSuccess(tasks, AddFixedDataTask) ): # no success dropping the table, but added data elif ( self.hasSuccess(tasks, AddFixedDataTask) ): # no success dropping the table, but added data
@ -556,11 +560,19 @@ class DbState():
if ( self.hasSuccess(tasks, DropFixedTableTask) ): if ( self.hasSuccess(tasks, DropFixedTableTask) ):
self.assertAtMostOneSuccess(tasks, DropFixedTableTask) self.assertAtMostOneSuccess(tasks, DropFixedTableTask)
self._state = self.STATE_DB_ONLY self._state = self.STATE_DB_ONLY
elif ( self.hasSuccess(tasks, AddFixedDataTask) ): # no success dropping the table else: # no success dropping the table, table remains intact in this step
self.assertNoTask(tasks, DropFixedTableTask) self.assertNoTask(tasks, DropFixedTableTask) # we should not have had such a task
self._state = self.STATE_HAS_DATA
else: # did not drop table, did not insert data, that is impossible if ( self.hasSuccess(tasks, AddFixedDataTask) ): # added data
raise RuntimeError("Unexpected no-success scenarios") self._state = self.STATE_HAS_DATA
else:
self.assertNoTask(tasks, AddFixedDataTask)
if ( self.hasSuccess(tasks, ReadFixedDataTask) ): # simple able to read some data
# which is ok, then no state change
self._state = self.STATE_HAS_DATA # no change
else: # did not drop table, did not insert data, that is impossible? yeah, we might only had ReadData task
raise RuntimeError("Unexpected no-success scenarios")
else: else:
raise RuntimeError("Unexpected DbState state: {}".format(self._state)) raise RuntimeError("Unexpected DbState state: {}".format(self._state))
@ -741,7 +753,7 @@ class AddDataTask(Task):
class AddFixedDataTask(Task): class AddFixedDataTask(Task):
def _executeInternal(self, te: TaskExecutor, wt: WorkerThread): def _executeInternal(self, te: TaskExecutor, wt: WorkerThread):
ds = self._dbState ds = self._dbState
sql = "insert into db.table_{} values ('{}', {});".format(ds.getFixedTableName(), ds.getNextTick(), ds.getNextInt()) sql = "insert into db.{} values ('{}', {});".format(ds.getFixedTableName(), ds.getNextTick(), ds.getNextInt())
wt.execSql(sql) wt.execSql(sql)
# Deterministic random number generator # Deterministic random number generator