xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

enh: check param

This commit is contained in:
factosea 2024-11-25 11:33:02 +08:00
parent 04af5f4b94
commit 22f3c20977
8 changed files with 33 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/libs/executor/src/aggregateoperator.c
View File

@ -337,7 +337,7 @@ static SSDataBlock* getAggregateResult(SOperatorInfo* pOperator) {
int32_t doAggregateImpl(SOperatorInfo* pOperator, SqlFunctionCtx* pCtx) { int32_t doAggregateImpl(SOperatorInfo* pOperator, SqlFunctionCtx* pCtx) {
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
if (pOperator || (pOperator->exprSupp.numOfExprs > 0 && pCtx == NULL)) { if (!pOperator || (pOperator->exprSupp.numOfExprs > 0 && pCtx == NULL)) {
qError("%s failed at line %d since pCtx is NULL.", __func__, __LINE__); qError("%s failed at line %d since pCtx is NULL.", __func__, __LINE__);
return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR; return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
} }

2
source/libs/executor/src/anomalywindowoperator.c
View File

@ -171,8 +171,6 @@ _error:
} }
static int32_t anomalyAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) { static int32_t anomalyAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
CHECK_CONDITION_FAILED(pOperator != NULL);
CHECK_CONDITION_FAILED(ppRes != NULL);
CHECK_CONDITION_FAILED(pOperator->info != NULL); CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL); CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;

3
source/libs/executor/src/countwindowoperator.c
View File

@ -225,6 +225,8 @@ _end:
} }
static int32_t countWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) { static int32_t countWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
int32_t lino = 0; int32_t lino = 0;
SCountWindowOperatorInfo* pInfo = pOperator->info; SCountWindowOperatorInfo* pInfo = pOperator->info;
@ -232,6 +234,7 @@ static int32_t countWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock**
SExprSupp* pExprSup = &pOperator->exprSupp; SExprSupp* pExprSup = &pOperator->exprSupp;
int32_t order = pInfo->binfo.inputTsOrder; int32_t order = pInfo->binfo.inputTsOrder;
SSDataBlock* pRes = pInfo->binfo.pRes; SSDataBlock* pRes = pInfo->binfo.pRes;
CHECK_CONDITION_FAILED(pRes != NULL);
blockDataCleanup(pRes); blockDataCleanup(pRes);

3
source/libs/executor/src/eventwindowoperator.c
View File

@ -182,6 +182,8 @@ void destroyEWindowOperatorInfo(void* param) {
} }
static int32_t eventWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) { static int32_t eventWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
int32_t lino = 0; int32_t lino = 0;
SEventWindowOperatorInfo* pInfo = pOperator->info; SEventWindowOperatorInfo* pInfo = pOperator->info;
@ -191,6 +193,7 @@ static int32_t eventWindowAggregateNext(SOperatorInfo* pOperator, SSDataBlock**
int32_t order = pInfo->binfo.inputTsOrder; int32_t order = pInfo->binfo.inputTsOrder;
SSDataBlock* pRes = pInfo->binfo.pRes; SSDataBlock* pRes = pInfo->binfo.pRes;
CHECK_CONDITION_FAILED(pRes != NULL);
blockDataCleanup(pRes); blockDataCleanup(pRes);

8
source/libs/executor/src/filloperator.c
View File

@ -182,9 +182,17 @@ static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
int32_t lino = 0; int32_t lino = 0;
SFillOperatorInfo* pInfo = pOperator->info; SFillOperatorInfo* pInfo = pOperator->info;
SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo; SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
if (pInfo == NULL || pTaskInfo == NULL) {
qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
return NULL;
}
SResultInfo* pResultInfo = &pOperator->resultInfo; SResultInfo* pResultInfo = &pOperator->resultInfo;
SSDataBlock* pResBlock = pInfo->pFinalRes; SSDataBlock* pResBlock = pInfo->pFinalRes;
if (pResBlock == NULL) {
qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
return NULL;
}
blockDataCleanup(pResBlock); blockDataCleanup(pResBlock);

7
source/libs/executor/src/groupoperator.c
View File

@ -444,6 +444,8 @@ _end:
} }
static int32_t hashGroupbyAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) { static int32_t hashGroupbyAggregateNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
int32_t lino = 0; int32_t lino = 0;
SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo; SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
@ -1003,11 +1005,14 @@ static int32_t hashPartitionNext(SOperatorInfo* pOperator, SSDataBlock** ppRes)
return TSDB_CODE_SUCCESS; return TSDB_CODE_SUCCESS;
} }
CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
int32_t lino = 0; int32_t lino = 0;
SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo; SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
SPartitionOperatorInfo* pInfo = pOperator->info; SPartitionOperatorInfo* pInfo = pOperator->info;
SSDataBlock* pRes = pInfo->binfo.pRes; SSDataBlock* pRes = pInfo->binfo.pRes;
CHECK_CONDITION_FAILED(pRes != NULL);
if (pOperator->status == OP_RES_TO_RETURN) { if (pOperator->status == OP_RES_TO_RETURN) {
(*ppRes) = buildPartitionResult(pOperator); (*ppRes) = buildPartitionResult(pOperator);
@ -1459,6 +1464,8 @@ static int32_t doStreamHashPartitionNext(SOperatorInfo* pOperator, SSDataBlock**
int32_t lino = 0; int32_t lino = 0;
SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo; SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
SStreamPartitionOperatorInfo* pInfo = pOperator->info; SStreamPartitionOperatorInfo* pInfo = pOperator->info;
CHECK_CONDITION_FAILED(pInfo != NULL);
CHECK_CONDITION_FAILED(pTaskInfo != NULL);
if (pOperator->status == OP_EXEC_DONE) { if (pOperator->status == OP_EXEC_DONE) {
(*ppRes) = NULL; (*ppRes) = NULL;

8
source/libs/executor/src/hashjoinoperator.c
View File

@ -904,8 +904,9 @@ static int32_t hJoinAddBlockRowsToHash(SSDataBlock* pBlock, SHJoinOperatorInfo*
static int32_t hJoinBuildHash(struct SOperatorInfo* pOperator, bool* queryDone) { static int32_t hJoinBuildHash(struct SOperatorInfo* pOperator, bool* queryDone) {
SHJoinOperatorInfo* pJoin = pOperator->info; SHJoinOperatorInfo* pJoin = pOperator->info;
SSDataBlock* pBlock = NULL; SSDataBlock* pBlock = NULL;
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
CHECK_CONDITION_FAILED(pJoin != NULL);
while (true) { while (true) {
pBlock = getNextBlockFromDownstream(pOperator, pJoin->pBuild->downStreamIdx); pBlock = getNextBlockFromDownstream(pOperator, pJoin->pBuild->downStreamIdx);
@ -990,12 +991,15 @@ void hJoinSetDone(struct SOperatorInfo* pOperator) {
} }
static int32_t hJoinMainProcess(struct SOperatorInfo* pOperator, SSDataBlock** pResBlock) { static int32_t hJoinMainProcess(struct SOperatorInfo* pOperator, SSDataBlock** pResBlock) {
CHECK_CONDITION_FAILED(pOperator->info != NULL);
CHECK_CONDITION_FAILED(pOperator->pTaskInfo != NULL);
SHJoinOperatorInfo* pJoin = pOperator->info; SHJoinOperatorInfo* pJoin = pOperator->info;
SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo; SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
int32_t code = TSDB_CODE_SUCCESS; int32_t code = TSDB_CODE_SUCCESS;
int32_t lino = 0; int32_t lino = 0;
SSDataBlock* pRes = pJoin->finBlk; SSDataBlock* pRes = pJoin->finBlk;
int64_t st = 0; int64_t st = 0;
CHECK_CONDITION_FAILED(pRes != NULL);
QRY_PARAM_CHECK(pResBlock); QRY_PARAM_CHECK(pResBlock);
if (pOperator->cost.openCost == 0) { if (pOperator->cost.openCost == 0) {

5
source/libs/executor/src/projectoperator.c
View File

@ -564,7 +564,7 @@ SSDataBlock* doApplyIndefinitFunction1(SOperatorInfo* pOperator) {
int32_t doApplyIndefinitFunction(SOperatorInfo* pOperator, SSDataBlock** pResBlock) { int32_t doApplyIndefinitFunction(SOperatorInfo* pOperator, SSDataBlock** pResBlock) {
QRY_PARAM_CHECK(pResBlock); QRY_PARAM_CHECK(pResBlock);
CHECK_CONDITION_FAILED(pOperator->info != NULL);
SIndefOperatorInfo* pIndefInfo = pOperator->info; SIndefOperatorInfo* pIndefInfo = pOperator->info;
SOptrBasicInfo* pInfo = &pIndefInfo->binfo; SOptrBasicInfo* pInfo = &pIndefInfo->binfo;
SExprSupp* pSup = &pOperator->exprSupp; SExprSupp* pSup = &pOperator->exprSupp;
@ -1178,5 +1178,8 @@ _exit:
if(processByRowFunctionCtx) { if(processByRowFunctionCtx) {
taosArrayDestroy(processByRowFunctionCtx); taosArrayDestroy(processByRowFunctionCtx);
} }
if(code) {
qError("project apply functions failed at: %s:%d", __func__, lino);
}
return code; return code;
} }