From 22b904b71100e2d3b0ab36f996fd3285f136d716 Mon Sep 17 00:00:00 2001
From: Benguang Zhao <bgzhao@taosdata.com>
Date: Fri, 24 Mar 2023 11:55:02 +0800
Subject: [PATCH] feat: not allowed to create a topic when WAL_RETENTION_PERIOD
 is zero

---
 source/dnode/mnode/impl/src/mndTopic.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/source/dnode/mnode/impl/src/mndTopic.c b/source/dnode/mnode/impl/src/mndTopic.c
index 6c284815f9..de2aee6dcc 100644
--- a/source/dnode/mnode/impl/src/mndTopic.c
+++ b/source/dnode/mnode/impl/src/mndTopic.c
@@ -605,6 +605,12 @@ static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq) {
     goto _OVER;
   }
 
+  if (pDb->cfg.walRetentionPeriod == 0) {
+    terrno = TSDB_CODE_MND_INVALID_DB_OPTION;
+    mError("db:%s, not allowed to create topic when WAL_RETENTION_PERIOD is zero", pDb->name);
+    goto _OVER;
+  }
+
   code = mndCreateTopic(pMnode, pReq, &createTopicReq, pDb, pReq->info.conn.user);
   if (code == 0) {
     code = TSDB_CODE_ACTION_IN_PROGRESS;