xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

prefer unsigned char * than void *, because we will add offset to the pointer

This commit is contained in:
freemine 2020-10-26 11:31:27 +08:00
parent 776e0a39c8
commit 1a5ec2e2ba
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/connector/odbc/src/todbc.c
View File

@ -1171,9 +1171,9 @@ static SQLRETURN do_bind_param_value(sql_t *sql, int idx_row, int idx, param_bin
return SQL_ERROR; return SQL_ERROR;
} }
SQLPOINTER paramValue = param->ParameterValue; unsigned char *paramValue = param->ParameterValue;
SQLSMALLINT valueType = param->ValueType; SQLSMALLINT valueType = param->ValueType;
SQLLEN *soi = param->StrLen_or_Ind; SQLLEN *soi = param->StrLen_or_Ind;
size_t offset = ((size_t)idx_row) * sql->rowlen + sql->ptr_offset; size_t offset = ((size_t)idx_row) * sql->rowlen + sql->ptr_offset;
@ -1636,7 +1636,7 @@ static SQLRETURN do_bind_param_value(sql_t *sql, int idx_row, int idx, param_bin
DASSERT(soi); DASSERT(soi);
DASSERT(*soi != SQL_NTS); DASSERT(*soi != SQL_NTS);
size_t bytes = 0; size_t bytes = 0;
SQLCHAR *utf8 = wchars_to_chars(paramValue, (size_t)*soi/2, &bytes); SQLCHAR *utf8 = wchars_to_chars((const SQLWCHAR*)paramValue, (size_t)*soi/2, &bytes);
bind->allocated = 1; bind->allocated = 1;
bind->u.bin = utf8; bind->u.bin = utf8;
bind->buffer_length = bytes; bind->buffer_length = bytes;
@ -1695,7 +1695,7 @@ static SQLRETURN do_bind_param_value(sql_t *sql, int idx_row, int idx, param_bin
size_t bytes = 0; size_t bytes = 0;
int r = 0; int r = 0;
int64_t t = 0; int64_t t = 0;
SQLCHAR *utf8 = wchars_to_chars(paramValue, (size_t)*soi/2, &bytes); SQLCHAR *utf8 = wchars_to_chars((const SQLWCHAR*)paramValue, (size_t)*soi/2, &bytes);
// why cast utf8 to 'char*' ? // why cast utf8 to 'char*' ?
r = taosParseTime((char*)utf8, &t, (int)strlen((const char*)utf8), TSDB_TIME_PRECISION_MILLI, 0); r = taosParseTime((char*)utf8, &t, (int)strlen((const char*)utf8), TSDB_TIME_PRECISION_MILLI, 0);
bind->u.v8 = t; bind->u.v8 = t;
@ -1751,7 +1751,7 @@ static SQLRETURN do_bind_param_value(sql_t *sql, int idx_row, int idx, param_bin
DASSERT(soi); DASSERT(soi);
DASSERT(*soi != SQL_NTS); DASSERT(*soi != SQL_NTS);
size_t bytes = 0; size_t bytes = 0;
SQLCHAR *utf8 = wchars_to_chars(paramValue, (size_t)(*soi/2), &bytes); SQLCHAR *utf8 = wchars_to_chars((const SQLWCHAR*)paramValue, (size_t)(*soi/2), &bytes);
bind->allocated = 1; bind->allocated = 1;
bind->u.nchar = (char*)utf8; bind->u.nchar = (char*)utf8;
bind->buffer_length = bytes; bind->buffer_length = bytes;