xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #18698 from taosdata/TS-2155-3.0 

fix(shell): forbid .taos_history record password for security
This commit is contained in:
dapan1121 2022-12-05 17:19:44 +08:00 committed by GitHub
parent c1b8d1b2b2 83f7c7c2d0
commit 17c6d303e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/shell/src/shellEngine.c
View File

@ -113,6 +113,13 @@ int32_t shellRunSingleCommand(char *command) {
}
void shellRecordCommandToHistory(char *command) {
if (strncasecmp(command, "create user ", 12) == 0 || strncasecmp(command, "alter user ", 11) == 0) {
if (taosStrCaseStr(command, " pass ")) {
// have password command forbid record to history because security
return;
}
}
SShellHistory *pHistory = &shell.history;
if (pHistory->hstart == pHistory->hend ||
pHistory->hist[(pHistory->hend + SHELL_MAX_HISTORY_SIZE - 1) % SHELL_MAX_HISTORY_SIZE] == NULL ||
@ -135,7 +142,7 @@ int32_t shellRunCommand(char *command, bool recordHistory) {
}
// add help or help;
if(strcmp(command, "help") == 0 || strcmp(command, "help;") == 0) {
if(strncasecmp(command, "help;", 5) == 0) {
showHelp();
return 0;
}