From 9aa1818a47532831bb272483bc2923efaf5749cd Mon Sep 17 00:00:00 2001 From: Ganlin Zhao Date: Tue, 18 Oct 2022 11:35:35 +0800 Subject: [PATCH 1/2] fix: coverity issues CID: 399614 --- source/common/src/tmisce.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/common/src/tmisce.c b/source/common/src/tmisce.c index f1713cfd98..dfaebc99f6 100644 --- a/source/common/src/tmisce.c +++ b/source/common/src/tmisce.c @@ -21,7 +21,8 @@ int32_t taosGetFqdnPortFromEp(const char* ep, SEp* pEp) { pEp->port = 0; - strcpy(pEp->fqdn, ep); + memset(pEp->fqdn, 0, TSDB_FQDN_LEN); + strncpy(pEp->fqdn, ep, TSDB_FQDN_LEN - 1); char* temp = strchr(pEp->fqdn, ':'); if (temp) { From 8dc5bb0ebbde85fca8f6a8684afbae4006a15e3f Mon Sep 17 00:00:00 2001 From: Ganlin Zhao Date: Tue, 18 Oct 2022 11:35:35 +0800 Subject: [PATCH 2/2] fix: coverity issues CID: 399632 --- source/common/src/tname.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/source/common/src/tname.c b/source/common/src/tname.c index 887c449c56..70682d6cd4 100644 --- a/source/common/src/tname.c +++ b/source/common/src/tname.c @@ -90,8 +90,10 @@ int64_t taosGetIntervalStartTimestamp(int64_t startTime, int64_t slidingTime, in SName* toName(int32_t acctId, const char* pDbName, const char* pTableName, SName* pName) { pName->type = TSDB_TABLE_NAME_T; pName->acctId = acctId; - strcpy(pName->dbname, pDbName); - strcpy(pName->tname, pTableName); + memset(pName->dbname, 0, TSDB_DB_NAME_LEN); + strncpy(pName->dbname, pDbName, TSDB_DB_NAME_LEN - 1); + memset(pName->tname, 0, TSDB_TABLE_NAME_LEN); + strncpy(pName->tname, pTableName, TSDB_TABLE_NAME_LEN - 1); return pName; }