xxq250
/
homework-jianmu
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix(stream): fix memory leak.

This commit is contained in:
Haojun Liao 2024-10-27 19:51:52 +08:00
parent 4802f59dfe
commit 0fa7bf1a26
1 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/libs/stream/src/streamMeta.c
View File

@ -100,16 +100,7 @@ void metaRefMgtCleanup() {
void* pIter = taosHashIterate(gMetaRefMgt.pTable, NULL); void* pIter = taosHashIterate(gMetaRefMgt.pTable, NULL);
while (pIter) { while (pIter) {
int64_t* p = *(int64_t**) pIter; int64_t* p = *(int64_t**) pIter;
stInfo("---------------free refId:%"PRId64", %p", *p, p);
taosMemoryFree(p); taosMemoryFree(p);
// SArray* list = *(SArray**)pIter;
// for (int i = 0; i < taosArrayGetSize(list); i++) {
// void* rid = taosArrayGetP(list, i);
// taosMemoryFree(rid);
// }
// taosArrayDestroy(list);
pIter = taosHashIterate(gMetaRefMgt.pTable, pIter); pIter = taosHashIterate(gMetaRefMgt.pTable, pIter);
} }
@ -127,13 +118,14 @@ int32_t metaRefMgtAdd(int64_t vgId, int64_t* rid) {
if (p == NULL) { if (p == NULL) {
code = taosHashPut(gMetaRefMgt.pTable, &rid, sizeof(rid), &rid, sizeof(void*)); code = taosHashPut(gMetaRefMgt.pTable, &rid, sizeof(rid), &rid, sizeof(void*));
if (code) { if (code) {
stError("vgId:%d failed to put into metaRef table, rid:%" PRId64, (int32_t)vgId, *rid); stError("vgId:%d failed to put into refId mgt, refId:%" PRId64" %p, code:%s", (int32_t)vgId, *rid, rid,
tstrerror(code));
return code; return code;
} else { } else { // not
stInfo("add refId:%"PRId64" vgId:%d, %p", *rid, (int32_t)vgId, rid); // stInfo("add refId:%"PRId64" vgId:%d, %p", *rid, (int32_t)vgId, rid);
} }
} else { } else {
// todo stFatal("try to add refId:%"PRId64" vgId:%d, %p that already added into mgt", *rid, (int32_t) vgId, rid);
} }
streamMutexUnlock(&gMetaRefMgt.mutex); streamMutexUnlock(&gMetaRefMgt.mutex);
@ -144,7 +136,7 @@ void metaRefMgtRemove(int64_t* pRefId) {
streamMutexLock(&gMetaRefMgt.mutex); streamMutexLock(&gMetaRefMgt.mutex);
taosHashRemove(gMetaRefMgt.pTable, &pRefId, sizeof(pRefId)); taosHashRemove(gMetaRefMgt.pTable, &pRefId, sizeof(pRefId));
stInfo("remove refId from mgt, refId:%"PRId64", %p", *pRefId, pRefId); taosMemoryFree(pRefId);
streamMutexUnlock(&gMetaRefMgt.mutex); streamMutexUnlock(&gMetaRefMgt.mutex);
} }