From 57cb65273401febe29121c503b3f1723a1631985 Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Fri, 18 Oct 2024 04:41:22 +0000
Subject: [PATCH 1/7] fix/TS-5532-set-seperate-thread-update-status

---
 source/dnode/mgmt/mgmt_dnode/inc/dmInt.h    |  2 +
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c |  9 ++++-
 source/dnode/mgmt/mgmt_dnode/src/dmInt.c    |  3 ++
 source/dnode/mgmt/mgmt_dnode/src/dmWorker.c | 45 +++++++++++++++++++++
 4 files changed, 57 insertions(+), 2 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h b/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
index 18b3f66a60..2d0b9c5a81 100644
--- a/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
+++ b/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
@@ -49,6 +49,7 @@ typedef struct SDnodeMgmt {
 // dmHandle.c
 SArray *dmGetMsgHandles();
 void    dmSendStatusReq(SDnodeMgmt *pMgmt);
+void    dmUpdateStatusInfo(SDnodeMgmt *pMgmt);
 void    dmSendNotifyReq(SDnodeMgmt *pMgmt, SNotifyReq *pReq);
 int32_t dmProcessConfigReq(SDnodeMgmt *pMgmt, SRpcMsg *pMsg);
 int32_t dmProcessAuthRsp(SDnodeMgmt *pMgmt, SRpcMsg *pMsg);
@@ -62,6 +63,7 @@ int32_t dmProcessCreateEncryptKeyReq(SDnodeMgmt *pMgmt, SRpcMsg *pMsg);
 // dmWorker.c
 int32_t dmPutNodeMsgToMgmtQueue(SDnodeMgmt *pMgmt, SRpcMsg *pMsg);
 int32_t dmStartStatusThread(SDnodeMgmt *pMgmt);
+int32_t dmStartStatusInfoThread(SDnodeMgmt *pMgmt);
 void    dmStopStatusThread(SDnodeMgmt *pMgmt);
 int32_t dmStartNotifyThread(SDnodeMgmt *pMgmt);
 void    dmStopNotifyThread(SDnodeMgmt *pMgmt);
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index 87b1ae0efa..7be3af0c25 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -22,6 +22,8 @@
 
 extern SConfig *tsCfg;
 
+SMonVloadInfo vinfo = {0};
+
 static void dmUpdateDnodeCfg(SDnodeMgmt *pMgmt, SDnodeCfg *pCfg) {
   int32_t code = 0;
   if (pMgmt->pData->dnodeId == 0 || pMgmt->pData->clusterId == 0) {
@@ -163,8 +165,6 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
   (void)taosThreadRwlockUnlock(&pMgmt->pData->lock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get vnode loads", pMgmt->statusSeq);
-  SMonVloadInfo vinfo = {0};
-  (*pMgmt->getVnodeLoadsFp)(&vinfo);
   req.pVloads = vinfo.pVloads;
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get mnode loads", pMgmt->statusSeq);
@@ -231,6 +231,11 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
   dmProcessStatusRsp(pMgmt, &rpcRsp);
 }
 
+void dmUpdateStatusInfo(SDnodeMgmt *pMgmt) {
+  dDebug("begin to get vnode loads");
+  (*pMgmt->getVnodeLoadsFp)(&vinfo);
+}
+
 void dmSendNotifyReq(SDnodeMgmt *pMgmt, SNotifyReq *pReq) {
   int32_t contLen = tSerializeSNotifyReq(NULL, 0, pReq);
   if (contLen < 0) {
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
index 22c2b2f5b2..701aa2d65e 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
@@ -22,6 +22,9 @@ static int32_t dmStartMgmt(SDnodeMgmt *pMgmt) {
   if ((code = dmStartStatusThread(pMgmt)) != 0) {
     return code;
   }
+  if ((code = dmStartStatusInfoThread(pMgmt)) != 0) {
+    return code;
+  }
 #if defined(TD_ENTERPRISE)
   if ((code = dmStartNotifyThread(pMgmt)) != 0) {
     return code;
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
index 58b86b20b1..7c9416fac6 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
@@ -47,6 +47,35 @@ static void *dmStatusThreadFp(void *param) {
   return NULL;
 }
 
+static void *dmStatusInfoThreadFp(void *param) {
+  SDnodeMgmt *pMgmt = param;
+  int64_t     lastTime = taosGetTimestampMs();
+  setThreadName("dnode-status-info");
+
+  int32_t upTimeCount = 0;
+  int64_t upTime = 0;
+
+  while (1) {
+    taosMsleep(200);
+    if (pMgmt->pData->dropped || pMgmt->pData->stopped) break;
+
+    int64_t curTime = taosGetTimestampMs();
+    if (curTime < lastTime) lastTime = curTime;
+    float interval = (curTime - lastTime) / 1000.0f;
+    if (interval >= tsStatusInterval) {
+      dmUpdateStatusInfo(pMgmt);
+      lastTime = curTime;
+
+      if ((upTimeCount = ((upTimeCount + 1) & 63)) == 0) {
+        upTime = taosGetOsUptime() - tsDndStartOsUptime;
+        tsDndUpTime = TMAX(tsDndUpTime, upTime);
+      }
+    }
+  }
+
+  return NULL;
+}
+
 SDmNotifyHandle dmNotifyHdl = {.state = 0};
 #define TIMESERIES_STASH_NUM 5
 static void *dmNotifyThreadFp(void *param) {
@@ -280,6 +309,22 @@ int32_t dmStartStatusThread(SDnodeMgmt *pMgmt) {
   return 0;
 }
 
+int32_t dmStartStatusInfoThread(SDnodeMgmt *pMgmt) {
+  int32_t      code = 0;
+  TdThreadAttr thAttr;
+  (void)taosThreadAttrInit(&thAttr);
+  (void)taosThreadAttrSetDetachState(&thAttr, PTHREAD_CREATE_JOINABLE);
+  if (taosThreadCreate(&pMgmt->statusThread, &thAttr, dmStatusInfoThreadFp, pMgmt) != 0) {
+    code = TAOS_SYSTEM_ERROR(errno);
+    dError("failed to create status Info thread since %s", tstrerror(code));
+    return code;
+  }
+
+  (void)taosThreadAttrDestroy(&thAttr);
+  tmsgReportStartup("dnode-status-info", "initialized");
+  return 0;
+}
+
 void dmStopStatusThread(SDnodeMgmt *pMgmt) {
   if (taosCheckPthreadValid(pMgmt->statusThread)) {
     (void)taosThreadJoin(pMgmt->statusThread, NULL);

From 295e4462d5da3ea526a52f4016da0df1f1b7c9df Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Fri, 18 Oct 2024 07:23:25 +0000
Subject: [PATCH 2/7] fix/TS-5532-set-seperate-thread-update-status-fix-case

---
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c | 13 +++++++++++--
 source/dnode/mgmt/node_mgmt/src/dmMgmt.c    |  1 +
 source/dnode/mgmt/node_util/inc/dmUtil.h    |  1 +
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index 7be3af0c25..1f4a46e887 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -22,7 +22,7 @@
 
 extern SConfig *tsCfg;
 
-SMonVloadInfo vinfo = {0};
+SMonVloadInfo tsVinfo = {0};
 
 static void dmUpdateDnodeCfg(SDnodeMgmt *pMgmt, SDnodeCfg *pCfg) {
   int32_t code = 0;
@@ -165,7 +165,11 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
   (void)taosThreadRwlockUnlock(&pMgmt->pData->lock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get vnode loads", pMgmt->statusSeq);
-  req.pVloads = vinfo.pVloads;
+  (void)taosThreadRwlockRdlock(&pMgmt->pData->statusInfolock);
+  req.pVloads = taosArrayDup(tsVinfo.pVloads, NULL);
+  taosArrayDestroy(tsVinfo.pVloads);
+  tsVinfo.pVloads = NULL;
+  (void)taosThreadRwlockUnlock(&pMgmt->pData->statusInfolock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get mnode loads", pMgmt->statusSeq);
   SMonMloadInfo minfo = {0};
@@ -232,8 +236,13 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
 }
 
 void dmUpdateStatusInfo(SDnodeMgmt *pMgmt) {
+  SMonVloadInfo vinfo = {0};
   dDebug("begin to get vnode loads");
   (*pMgmt->getVnodeLoadsFp)(&vinfo);
+  (void)taosThreadRwlockWrlock(&pMgmt->pData->statusInfolock);
+  if (tsVinfo.pVloads == NULL) tsVinfo.pVloads = taosArrayDup(vinfo.pVloads, NULL);
+  taosArrayDestroy(vinfo.pVloads);
+  (void)taosThreadRwlockWrlock(&pMgmt->pData->statusInfolock);
 }
 
 void dmSendNotifyReq(SDnodeMgmt *pMgmt, SNotifyReq *pReq) {
diff --git a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
index 277dd2e02a..4fc618379c 100644
--- a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
+++ b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
@@ -214,6 +214,7 @@ int32_t dmInitVars(SDnode *pDnode) {
   }
 
   (void)taosThreadRwlockInit(&pData->lock, NULL);
+  (void)taosThreadRwlockInit(&pData->statusInfolock, NULL);
   (void)taosThreadMutexInit(&pDnode->mutex, NULL);
   return 0;
 }
diff --git a/source/dnode/mgmt/node_util/inc/dmUtil.h b/source/dnode/mgmt/node_util/inc/dmUtil.h
index b5842acbad..2374c45c2d 100644
--- a/source/dnode/mgmt/node_util/inc/dmUtil.h
+++ b/source/dnode/mgmt/node_util/inc/dmUtil.h
@@ -144,6 +144,7 @@ typedef struct {
   char           machineId[TSDB_MACHINE_ID_LEN + 1];
   EEncryptAlgor  encryptAlgorigthm;
   EEncryptScope  encryptScope;
+  TdThreadRwlock statusInfolock;
 } SDnodeData;
 
 typedef struct {

From 7e7be90b69004b203e1d246b47872af4900f6980 Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Fri, 18 Oct 2024 07:51:52 +0000
Subject: [PATCH 3/7] fix/TS-5532-set-seperate-thrad-update-status-fix-case

---
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c | 8 ++++----
 source/dnode/mgmt/node_mgmt/src/dmMgmt.c    | 2 +-
 source/dnode/mgmt/node_util/inc/dmUtil.h    | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index 1f4a46e887..08fd632831 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -165,11 +165,11 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
   (void)taosThreadRwlockUnlock(&pMgmt->pData->lock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get vnode loads", pMgmt->statusSeq);
-  (void)taosThreadRwlockRdlock(&pMgmt->pData->statusInfolock);
+  (void)taosThreadMutexLock(&pMgmt->pData->statusInfolock);
   req.pVloads = taosArrayDup(tsVinfo.pVloads, NULL);
   taosArrayDestroy(tsVinfo.pVloads);
   tsVinfo.pVloads = NULL;
-  (void)taosThreadRwlockUnlock(&pMgmt->pData->statusInfolock);
+  (void)taosThreadMutexUnlock(&pMgmt->pData->statusInfolock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get mnode loads", pMgmt->statusSeq);
   SMonMloadInfo minfo = {0};
@@ -239,10 +239,10 @@ void dmUpdateStatusInfo(SDnodeMgmt *pMgmt) {
   SMonVloadInfo vinfo = {0};
   dDebug("begin to get vnode loads");
   (*pMgmt->getVnodeLoadsFp)(&vinfo);
-  (void)taosThreadRwlockWrlock(&pMgmt->pData->statusInfolock);
+  (void)taosThreadMutexLock(&pMgmt->pData->statusInfolock);
   if (tsVinfo.pVloads == NULL) tsVinfo.pVloads = taosArrayDup(vinfo.pVloads, NULL);
   taosArrayDestroy(vinfo.pVloads);
-  (void)taosThreadRwlockWrlock(&pMgmt->pData->statusInfolock);
+  (void)taosThreadMutexUnlock(&pMgmt->pData->statusInfolock);
 }
 
 void dmSendNotifyReq(SDnodeMgmt *pMgmt, SNotifyReq *pReq) {
diff --git a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
index 4fc618379c..5e4f7163e7 100644
--- a/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
+++ b/source/dnode/mgmt/node_mgmt/src/dmMgmt.c
@@ -214,7 +214,7 @@ int32_t dmInitVars(SDnode *pDnode) {
   }
 
   (void)taosThreadRwlockInit(&pData->lock, NULL);
-  (void)taosThreadRwlockInit(&pData->statusInfolock, NULL);
+  (void)taosThreadMutexInit(&pData->statusInfolock, NULL);
   (void)taosThreadMutexInit(&pDnode->mutex, NULL);
   return 0;
 }
diff --git a/source/dnode/mgmt/node_util/inc/dmUtil.h b/source/dnode/mgmt/node_util/inc/dmUtil.h
index 2374c45c2d..de20f807e9 100644
--- a/source/dnode/mgmt/node_util/inc/dmUtil.h
+++ b/source/dnode/mgmt/node_util/inc/dmUtil.h
@@ -144,7 +144,7 @@ typedef struct {
   char           machineId[TSDB_MACHINE_ID_LEN + 1];
   EEncryptAlgor  encryptAlgorigthm;
   EEncryptScope  encryptScope;
-  TdThreadRwlock statusInfolock;
+  TdThreadMutex  statusInfolock;
 } SDnodeData;
 
 typedef struct {

From 66e58ee08ff5ef411b5bde632baa4cd4fa7233dc Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Fri, 18 Oct 2024 08:36:41 +0000
Subject: [PATCH 4/7] fix/TS-5532-set-seperate-thread-update-status-fix-case

---
 source/dnode/mgmt/mgmt_dnode/inc/dmInt.h    | 2 ++
 source/dnode/mgmt/mgmt_dnode/src/dmInt.c    | 1 +
 source/dnode/mgmt/mgmt_dnode/src/dmWorker.c | 9 ++++++++-
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h b/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
index 2d0b9c5a81..cbf1959e75 100644
--- a/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
+++ b/source/dnode/mgmt/mgmt_dnode/inc/dmInt.h
@@ -28,6 +28,7 @@ typedef struct SDnodeMgmt {
   const char                  *path;
   const char                  *name;
   TdThread                     statusThread;
+  TdThread                     statusInfoThread;
   TdThread                     notifyThread;
   TdThread                     monitorThread;
   TdThread                     auditThread;
@@ -65,6 +66,7 @@ int32_t dmPutNodeMsgToMgmtQueue(SDnodeMgmt *pMgmt, SRpcMsg *pMsg);
 int32_t dmStartStatusThread(SDnodeMgmt *pMgmt);
 int32_t dmStartStatusInfoThread(SDnodeMgmt *pMgmt);
 void    dmStopStatusThread(SDnodeMgmt *pMgmt);
+void    dmStopStatusInfoThread(SDnodeMgmt *pMgmt);
 int32_t dmStartNotifyThread(SDnodeMgmt *pMgmt);
 void    dmStopNotifyThread(SDnodeMgmt *pMgmt);
 int32_t dmStartMonitorThread(SDnodeMgmt *pMgmt);
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
index 701aa2d65e..ed156ac1ec 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmInt.c
@@ -47,6 +47,7 @@ static void dmStopMgmt(SDnodeMgmt *pMgmt) {
   dmStopMonitorThread(pMgmt);
   dmStopAuditThread(pMgmt);
   dmStopStatusThread(pMgmt);
+  dmStopStatusInfoThread(pMgmt);
 #if defined(TD_ENTERPRISE)
   dmStopNotifyThread(pMgmt);
 #endif
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
index 7c9416fac6..7f802f3837 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
@@ -314,7 +314,7 @@ int32_t dmStartStatusInfoThread(SDnodeMgmt *pMgmt) {
   TdThreadAttr thAttr;
   (void)taosThreadAttrInit(&thAttr);
   (void)taosThreadAttrSetDetachState(&thAttr, PTHREAD_CREATE_JOINABLE);
-  if (taosThreadCreate(&pMgmt->statusThread, &thAttr, dmStatusInfoThreadFp, pMgmt) != 0) {
+  if (taosThreadCreate(&pMgmt->statusInfoThread, &thAttr, dmStatusInfoThreadFp, pMgmt) != 0) {
     code = TAOS_SYSTEM_ERROR(errno);
     dError("failed to create status Info thread since %s", tstrerror(code));
     return code;
@@ -332,6 +332,13 @@ void dmStopStatusThread(SDnodeMgmt *pMgmt) {
   }
 }
 
+void dmStopStatusInfoThread(SDnodeMgmt *pMgmt) {
+  if (taosCheckPthreadValid(pMgmt->statusInfoThread)) {
+    (void)taosThreadJoin(pMgmt->statusInfoThread, NULL);
+    taosThreadClear(&pMgmt->statusInfoThread);
+  }
+}
+
 int32_t dmStartNotifyThread(SDnodeMgmt *pMgmt) {
   int32_t      code = 0;
   TdThreadAttr thAttr;

From 2437030f1a9e68646e065a87cbe191486f823755 Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Mon, 21 Oct 2024 01:32:18 +0000
Subject: [PATCH 5/7] fix/TS-5532-set-seperate-thread-update-status-fix-review

---
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c | 31 +++++++++++++++------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index 08fd632831..e80cdf0471 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -165,11 +165,16 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
   (void)taosThreadRwlockUnlock(&pMgmt->pData->lock);
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get vnode loads", pMgmt->statusSeq);
-  (void)taosThreadMutexLock(&pMgmt->pData->statusInfolock);
-  req.pVloads = taosArrayDup(tsVinfo.pVloads, NULL);
-  taosArrayDestroy(tsVinfo.pVloads);
+  if (taosThreadMutexLock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to lock status info lock");
+    return;
+  }
+  taosArraySwap(req.pVloads, tsVinfo.pVloads);
   tsVinfo.pVloads = NULL;
-  (void)taosThreadMutexUnlock(&pMgmt->pData->statusInfolock);
+  if (taosThreadMutexUnlock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to unlock status info lock");
+    return;
+  }
 
   dDebug("send status req to mnode, statusSeq:%d, begin to get mnode loads", pMgmt->statusSeq);
   SMonMloadInfo minfo = {0};
@@ -239,10 +244,20 @@ void dmUpdateStatusInfo(SDnodeMgmt *pMgmt) {
   SMonVloadInfo vinfo = {0};
   dDebug("begin to get vnode loads");
   (*pMgmt->getVnodeLoadsFp)(&vinfo);
-  (void)taosThreadMutexLock(&pMgmt->pData->statusInfolock);
-  if (tsVinfo.pVloads == NULL) tsVinfo.pVloads = taosArrayDup(vinfo.pVloads, NULL);
-  taosArrayDestroy(vinfo.pVloads);
-  (void)taosThreadMutexUnlock(&pMgmt->pData->statusInfolock);
+  if (taosThreadMutexLock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to lock status info lock");
+    return;
+  }
+  if (tsVinfo.pVloads == NULL) {
+    taosArraySwap(tsVinfo.pVloads, vinfo.pVloads);
+  } else {
+    taosArrayDestroy(vinfo.pVloads);
+    vinfo.pVloads = NULL;
+  }
+  if (taosThreadMutexUnlock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to unlock status info lock");
+    return;
+  }
 }
 
 void dmSendNotifyReq(SDnodeMgmt *pMgmt, SNotifyReq *pReq) {

From 9d2b4eba5a470311367eda712f53ff3aa3354eed Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Mon, 21 Oct 2024 03:52:42 +0000
Subject: [PATCH 6/7] fix/TS-5532-set-seperate-thread-update-status-fix-case

---
 source/dnode/mgmt/mgmt_dnode/src/dmWorker.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
index 7f802f3837..075cd0efce 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
@@ -47,6 +47,7 @@ static void *dmStatusThreadFp(void *param) {
   return NULL;
 }
 
+extern SMonVloadInfo tsVinfo;
 static void *dmStatusInfoThreadFp(void *param) {
   SDnodeMgmt *pMgmt = param;
   int64_t     lastTime = taosGetTimestampMs();
@@ -73,6 +74,19 @@ static void *dmStatusInfoThreadFp(void *param) {
     }
   }
 
+  if (taosThreadMutexLock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to lock status info lock");
+    return NULL;
+  }
+  if (tsVinfo.pVloads != NULL) {
+    taosArrayDestroy(tsVinfo.pVloads);
+    tsVinfo.pVloads = NULL;
+  }
+  if (taosThreadMutexUnlock(&pMgmt->pData->statusInfolock) != 0) {
+    dError("failed to unlock status info lock");
+    return NULL;
+  }
+
   return NULL;
 }
 

From c454d0f0763af938879aeb2334a96cfdcdafc43d Mon Sep 17 00:00:00 2001
From: dmchen <cademfly@hotmail.com>
Date: Mon, 21 Oct 2024 06:19:04 +0000
Subject: [PATCH 7/7] fix/TS-5532-set-seperate-thread-update-status-fix-case

---
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c | 6 ++++--
 source/dnode/mgmt/mgmt_dnode/src/dmWorker.c | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index e80cdf0471..d0f8fbae87 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -169,7 +169,7 @@ void dmSendStatusReq(SDnodeMgmt *pMgmt) {
     dError("failed to lock status info lock");
     return;
   }
-  taosArraySwap(req.pVloads, tsVinfo.pVloads);
+  req.pVloads = tsVinfo.pVloads;
   tsVinfo.pVloads = NULL;
   if (taosThreadMutexUnlock(&pMgmt->pData->statusInfolock) != 0) {
     dError("failed to unlock status info lock");
@@ -244,12 +244,14 @@ void dmUpdateStatusInfo(SDnodeMgmt *pMgmt) {
   SMonVloadInfo vinfo = {0};
   dDebug("begin to get vnode loads");
   (*pMgmt->getVnodeLoadsFp)(&vinfo);
+  dDebug("begin to lock status info");
   if (taosThreadMutexLock(&pMgmt->pData->statusInfolock) != 0) {
     dError("failed to lock status info lock");
     return;
   }
   if (tsVinfo.pVloads == NULL) {
-    taosArraySwap(tsVinfo.pVloads, vinfo.pVloads);
+    tsVinfo.pVloads = vinfo.pVloads;
+    vinfo.pVloads = NULL;
   } else {
     taosArrayDestroy(vinfo.pVloads);
     vinfo.pVloads = NULL;
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
index 075cd0efce..7fc9920816 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmWorker.c
@@ -73,7 +73,7 @@ static void *dmStatusInfoThreadFp(void *param) {
       }
     }
   }
-
+  dDebug("begin to lock status info when thread exit");
   if (taosThreadMutexLock(&pMgmt->pData->statusInfolock) != 0) {
     dError("failed to lock status info lock");
     return NULL;