[TD-52] refactor interface

cmake/define.inc

@@ -6,7 +6,7 @@ IF (TD_SYNC)
 ENDIF ()
 
 IF (TD_ACCOUNT)
-  ADD_DEFINITIONS(-D_ACCOUNT)
+  ADD_DEFINITIONS(-D_ACCT)
 ENDIF ()
 
 IF (TD_ADMIN)

cmake/input.inc

@@ -1,14 +1,6 @@
 CMAKE_MINIMUM_REQUIRED(VERSION 2.8)
 PROJECT(TDengine)
 
-IF (${CLUSTER} MATCHES "true")
-  SET(TD_CLUSTER TRUE)
-  MESSAGE(STATUS "Build with cluster plugins")
-ELSEIF (${CLUSTER} MATCHES "false")
-  SET(TD_CLUSTER FALSE)
-  MESSAGE(STATUS "Build without cluster plugins")
-ENDIF ()
-
 IF (${ACCOUNT} MATCHES "true")
   SET(TD_ACCOUNT TRUE)
   MESSAGE(STATUS "Build with account plugins")

src/dnode/inc/dnodeMClient.h

@@ -23,7 +23,7 @@ extern "C" {
 int32_t  dnodeInitMClient();
 void     dnodeCleanupMClient();
 void     dnodeSendMsgToMnode(SRpcMsg *rpcMsg);
-void *   dnodeGetMpeerInfos();
+void *   dnodeGetMnodeList();
 int32_t  dnodeGetDnodeId();
 
 #ifdef __cplusplus

src/dnode/src/dnodeMClient.c

@@ -332,7 +332,7 @@ uint32_t dnodeGetMnodeMasteIp() {
   return tsMnodeIpList.ip[tsMnodeIpList.inUse];
 }
 
-void* dnodeGetMpeerInfos() {
+void* dnodeGetMnodeList() {
   return &tsMnodeInfos;
 }
 

src/inc/mnode.h

@@ -25,9 +25,6 @@ int32_t mgmtStartSystem();
 void    mgmtCleanUpSystem();
 void    mgmtStopSystem();
 
-extern char  version[];
-extern char  tsMnodeDir[];
-
 #ifdef __cplusplus
 }
 #endif

src/inc/tadmin.h

@@ -20,15 +20,10 @@
 extern "C" {
 #endif
 
-#include <stdint.h>
+struct HttpServer;
-#include <stdbool.h>
 
-void adminInit();
+void adminInitHandle(struct HttpServer* pServer);
-
+void opInitHandle(struct HttpServer* pServer);
-struct _http_server_obj_;
-
-extern void (*adminInitHandleFp)(struct _http_server_obj_* pServer);
-extern void (*opInitHandleFp)(struct _http_server_obj_* pServer);
 
 #ifdef __cplusplus
 }

src/mnode/src/mgmtAcct.c

@@ -26,9 +26,9 @@
 #include "mgmtSdb.h"
 #include "mgmtUser.h"
 
-static void *  tsAcctSdb = NULL;
+void *  tsAcctSdb = NULL;
-static int32_t tsAcctUpdateSize;
+int32_t tsAcctUpdateSize;
-static void    mgmtCreateRootAcct();
+static void mgmtCreateRootAcct();
 
 static int32_t mgmtActionAcctDestroy(SSdbOperDesc *pOper) {
   SAcctObj *pAcct = pOper->pObj;

src/mnode/src/mgmtMnode.c

@@ -30,9 +30,9 @@
 #include "mgmtShell.h"
 #include "mgmtUser.h"
 
+int32_t tsMnodeIsMaster = true;
 static void *  tsMnodeSdb = NULL;
 static int32_t tsMnodeUpdateSize = 0;
-static int32_t tsMnodeIsMaster = true;
 static int32_t mgmtGetMnodeMeta(STableMetaMsg *pMeta, SShowObj *pShow, void *pConn);
 static int32_t mgmtRetrieveMnodes(SShowObj *pShow, char *data, int32_t rows, void *pConn);
 

src/mnode/src/mgmtReplica.c

@@ -64,4 +64,7 @@ int32_t replicaAllocVnodes(SVgObj *pVgroup) {
   return TSDB_CODE_SUCCESS;
 }
 
+tsync_h syncStart(const SSyncInfo *info) { return NULL; }
+int     syncForwardToPeer(tsync_h shandle, void *pHead, void *mhandle) { return 0; }
+
 #endif 

src/plugins/http/CMakeLists.txt

@@ -15,7 +15,7 @@ IF ((TD_LINUX_64) OR (TD_LINUX_32 AND TD_ARM))
   ADD_LIBRARY(http ${SRC})
   TARGET_LINK_LIBRARIES(http taos_static z)
 
-  IF (TD_CLUSTER)
+  IF (TD_ADMIN)
-    TARGET_LINK_LIBRARIES(http)
+    TARGET_LINK_LIBRARIES(http admin)
   ENDIF ()
 ENDIF ()

src/plugins/http/inc/httpHandle.h

@@ -23,7 +23,7 @@
 #include "taosdef.h"
 #include "tutil.h"
 #include "zlib.h"
-
+#include "tlog.h"
 #include "http.h"
 #include "httpJson.h"
 
@@ -206,10 +206,10 @@ typedef struct HttpThread {
   int             threadId;
   char            label[HTTP_LABEL_SIZE];
   bool (*processData)(HttpContext *pContext);
-  struct _http_server_obj_ *pServer;  // handle passed by upper layer during pServer initialization
+  struct HttpServer *pServer;  // handle passed by upper layer during pServer initialization
 } HttpThread;
 
-typedef struct _http_server_obj_ {
+typedef struct HttpServer {
   char              label[HTTP_LABEL_SIZE];
   char              serverIp[16];
   uint16_t          serverPort;
@@ -313,4 +313,27 @@ const char* httpContextStateStr(HttpContextState state);
 bool httpAlterContextState(HttpContext *pContext, HttpContextState srcState, HttpContextState destState);
 void httpRemoveContextFromEpoll(HttpThread *pThread, HttpContext *pContext);
 
+#define httpError(...)                       \
+  if (httpDebugFlag & DEBUG_ERROR) {         \
+    tprintf("ERROR HTP ", 255, __VA_ARGS__); \
+  }
+#define httpWarn(...)                                  \
+  if (httpDebugFlag & DEBUG_WARN) {                    \
+    tprintf("WARN  HTP ", httpDebugFlag, __VA_ARGS__); \
+  }
+#define httpTrace(...)                           \
+  if (httpDebugFlag & DEBUG_TRACE) {             \
+    tprintf("HTP ", httpDebugFlag, __VA_ARGS__); \
+  }
+#define httpDump(...)                                        \
+  if (httpDebugFlag & DEBUG_TRACE) {                         \
+    taosPrintLongString("HTP ", httpDebugFlag, __VA_ARGS__); \
+  }
+#define httpPrint(...) \
+  { tprintf("HTP ", 255, __VA_ARGS__); }
+
+#define httpLError(...) taosLogError(__VA_ARGS__) httpError(__VA_ARGS__)
+#define httpLWarn(...) taosLogWarn(__VA_ARGS__) httpWarn(__VA_ARGS__)
+#define httpLPrint(...) taosLogPrint(__VA_ARGS__) httpPrint(__VA_ARGS__)
+
 #endif

src/plugins/http/src/httpSystem.c

@@ -13,11 +13,9 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <arpa/inet.h>
+#define _DEFAULT_SOURCE
-#include <stdint.h>
+#include "os.h"
-#include <string.h>
+#include "tadmin.h"
-#include <unistd.h>
-
 #include "http.h"
 #include "httpCode.h"
 #include "httpHandle.h"
@@ -27,28 +25,17 @@
 #include "tglobalcfg.h"
 #include "tsocket.h"
 #include "ttimer.h"
-
 #include "gcHandle.h"
 #include "httpHandle.h"
 #include "restHandle.h"
 #include "tgHandle.h"
-#include "tlog.h"
 
+#ifndef _ADMIN
 
-void (*adminInitHandleFp)(HttpServer* pServer) = NULL;
+void adminInitHandle(HttpServer* pServer) {}
-void (*opInitHandleFp)(HttpServer* pServer) = NULL;
+void opInitHandle(HttpServer* pServer) {}
 
-void adminInitHandle(HttpServer* pServer) {
+#endif
-  if (adminInitHandleFp) {
-    (*adminInitHandleFp)(pServer);
-  }
-}
-
-void opInitHandle(HttpServer* pServer) {
-  if (opInitHandleFp) {
-    (*opInitHandleFp)(pServer);
-  }
-}
 
 static HttpServer *httpServer = NULL;
 void taosInitNote(int numOfNoteLines, int maxNotes, char* lable);

src/plugins/monitor/src/monitorSystem.c

@@ -13,17 +13,37 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
+#define _DEFAULT_SOURCE
 #include "os.h"
-
+#include "tlog.h"
 #include "monitor.h"
 #include "dnode.h"
-#include "monitorSystem.h"
 #include "tsclient.h"
 #include "taosdef.h"
 #include "tsystem.h"
 #include "ttime.h"
 #include "ttimer.h"
 #include "tutil.h"
+#include "monitorSystem.h"
+
+#define monitorError(...)                    \
+  if (monitorDebugFlag & DEBUG_ERROR) {      \
+    tprintf("ERROR MON ", 255, __VA_ARGS__); \
+  }
+#define monitorWarn(...)                                  \
+  if (monitorDebugFlag & DEBUG_WARN) {                    \
+    tprintf("WARN  MON ", monitorDebugFlag, __VA_ARGS__); \
+  }
+#define monitorTrace(...)                           \
+  if (monitorDebugFlag & DEBUG_TRACE) {             \
+    tprintf("MON ", monitorDebugFlag, __VA_ARGS__); \
+  }
+#define monitorPrint(...) \
+  { tprintf("MON ", 255, __VA_ARGS__); }
+
+#define monitorLError(...) taosLogError(__VA_ARGS__) monitorError(__VA_ARGS__)
+#define monitorLWarn(...) taosLogWarn(__VA_ARGS__) monitorWarn(__VA_ARGS__)
+#define monitorLPrint(...) taosLogPrint(__VA_ARGS__) monitorPrint(__VA_ARGS__)
 
 #define SQL_LENGTH     1024
 #define LOG_LEN_STR    80

src/util/CMakeLists.txt

@@ -107,8 +107,4 @@ ELSEIF(TD_DARWIN_64)
   TARGET_LINK_LIBRARIES(tutil iconv pthread os)
 ENDIF()
 
-#IF (TD_CLUSTER)
 #  TARGET_LINK_LIBRARIES(tutil mstorage)
-#ENDIF ()
-
-

src/util/inc/tlog.h

@@ -177,48 +177,6 @@ extern uint32_t cdebugFlag;
     tprintf("DND QRY ", qdebugFlag, __VA_ARGS__); \
   }
 
-#define httpError(...)                       \
-  if (httpDebugFlag & DEBUG_ERROR) {         \
-    tprintf("ERROR HTP ", 255, __VA_ARGS__); \
-  }
-#define httpWarn(...)                                  \
-  if (httpDebugFlag & DEBUG_WARN) {                    \
-    tprintf("WARN  HTP ", httpDebugFlag, __VA_ARGS__); \
-  }
-#define httpTrace(...)                           \
-  if (httpDebugFlag & DEBUG_TRACE) {             \
-    tprintf("HTP ", httpDebugFlag, __VA_ARGS__); \
-  }
-#define httpDump(...)                                        \
-  if (httpDebugFlag & DEBUG_TRACE) {                         \
-    taosPrintLongString("HTP ", httpDebugFlag, __VA_ARGS__); \
-  }
-#define httpPrint(...) \
-  { tprintf("HTP ", 255, __VA_ARGS__); }
-
-#define httpLError(...) taosLogError(__VA_ARGS__) httpError(__VA_ARGS__)
-#define httpLWarn(...) taosLogWarn(__VA_ARGS__) httpWarn(__VA_ARGS__)
-#define httpLPrint(...) taosLogPrint(__VA_ARGS__) httpPrint(__VA_ARGS__)
-
-#define monitorError(...)                    \
-  if (monitorDebugFlag & DEBUG_ERROR) {      \
-    tprintf("ERROR MON ", 255, __VA_ARGS__); \
-  }
-#define monitorWarn(...)                                  \
-  if (monitorDebugFlag & DEBUG_WARN) {                    \
-    tprintf("WARN  MON ", monitorDebugFlag, __VA_ARGS__); \
-  }
-#define monitorTrace(...)                           \
-  if (monitorDebugFlag & DEBUG_TRACE) {             \
-    tprintf("MON ", monitorDebugFlag, __VA_ARGS__); \
-  }
-#define monitorPrint(...) \
-  { tprintf("MON ", 255, __VA_ARGS__); }
-
-#define monitorLError(...) taosLogError(__VA_ARGS__) monitorError(__VA_ARGS__)
-#define monitorLWarn(...) taosLogWarn(__VA_ARGS__) monitorWarn(__VA_ARGS__)
-#define monitorLPrint(...) taosLogPrint(__VA_ARGS__) monitorPrint(__VA_ARGS__)
-
 #ifdef __cplusplus
 }
 #endif

src/vnode/src/vnodeMain.c

@@ -41,12 +41,6 @@ static int      vnodeGetWalInfo(void *ahandle, char *name, uint32_t *index);
 static void     vnodeNotifyRole(void *ahandle, int8_t role);
 
 static pthread_once_t  vnodeModuleInit = PTHREAD_ONCE_INIT;
-
-#ifndef _VPEER
-tsync_h syncStart(const SSyncInfo *info) { return NULL; }
-int     syncForwardToPeer(tsync_h shandle, void *pHead, void *mhandle) { return 0; }
-#endif
-
 static void vnodeInit() {
   vnodeInitWriteFp();
   vnodeInitReadFp();