From 000325f7169ce02599a0063ad3535ac94c064076 Mon Sep 17 00:00:00 2001
From: Haojun Liao <hjliao@taosdata.com>
Date: Sun, 25 Jun 2023 19:30:21 +0800
Subject: [PATCH] fix(stream): fix memory leak.

---
 source/dnode/mnode/impl/src/mndScheduler.c | 4 +++-
 source/dnode/mnode/impl/src/mndStream.c    | 2 --
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/source/dnode/mnode/impl/src/mndScheduler.c b/source/dnode/mnode/impl/src/mndScheduler.c
index e69f874f41..c2e5716c23 100644
--- a/source/dnode/mnode/impl/src/mndScheduler.c
+++ b/source/dnode/mnode/impl/src/mndScheduler.c
@@ -546,14 +546,16 @@ static int32_t addSourceTasksForMultiLevelStream(SMnode* pMnode, SQueryPlan* pPl
     if (pStream->conf.fillHistory) {
       code = doAddSourceTask(pHSourceTaskList, pStream->conf.fillHistory, pStream->hTaskUid, pHDownstreamTask, pMnode,
                              plan, pVgroup);
-      sdbRelease(pSdb, pVgroup);
 
       if (code != TSDB_CODE_SUCCESS) {
+        sdbRelease(pSdb, pVgroup);
         return code;
       }
 
       setHTasksId(pSourceTaskList, pHSourceTaskList);
     }
+
+    sdbRelease(pSdb, pVgroup);
   }
 
   return TSDB_CODE_SUCCESS;
diff --git a/source/dnode/mnode/impl/src/mndStream.c b/source/dnode/mnode/impl/src/mndStream.c
index e78411096f..433f3fe272 100644
--- a/source/dnode/mnode/impl/src/mndStream.c
+++ b/source/dnode/mnode/impl/src/mndStream.c
@@ -1001,8 +1001,6 @@ static int32_t mndProcessStreamDoCheckpoint(SRpcMsg *pReq) {
 static int32_t mndProcessDropStreamReq(SRpcMsg *pReq) {
   SMnode     *pMnode = pReq->info.node;
   SStreamObj *pStream = NULL;
-  /*SDbObj     *pDb = NULL;*/
-  /*SUserObj   *pUser = NULL;*/
 
   SMDropStreamReq dropReq = {0};
   if (tDeserializeSMDropStreamReq(pReq->pCont, pReq->contLen, &dropReq) < 0) {