4588653b24
ruff is faster and handle everything we had prior. isort configuration done based on the indication from https://github.com/astral-sh/ruff/issues/4670, previousely based on reorder-python-import (#11896) flake8-docstrings was a wrapper around pydocstyle (now archived) that explicitly asks to use ruff in https://github.com/PyCQA/pydocstyle/pull/658. flake8-typing-import is useful mainly for project that support python 3.7 and the one useful check will be implemented in https://github.com/astral-sh/ruff/issues/2302 We need to keep blacken-doc because ruff does not handle detection of python code inside .md and .rst. The direct link to the repo is now used to avoid a redirection. Manual fixes: - Lines that became too long - % formatting that was not done automatically - type: ignore that were moved around - noqa of hard to fix issues (UP031 generally) - fmt: off and fmt: on that is not really identical between black and ruff - autofix re-order in pre-commit from faster to slower Co-authored-by: Ran Benita <ran@unusedvar.com>
147 lines
4.3 KiB
Python
147 lines
4.3 KiB
Python
# mypy: allow-untyped-defs
|
|
from pathlib import Path
|
|
import re
|
|
from typing import cast
|
|
from typing import Type
|
|
import warnings
|
|
|
|
from _pytest import nodes
|
|
from _pytest.outcomes import OutcomeException
|
|
from _pytest.pytester import Pytester
|
|
from _pytest.warning_types import PytestWarning
|
|
import pytest
|
|
|
|
|
|
def test_node_from_parent_disallowed_arguments() -> None:
|
|
with pytest.raises(TypeError, match="session is"):
|
|
nodes.Node.from_parent(None, session=None) # type: ignore[arg-type]
|
|
with pytest.raises(TypeError, match="config is"):
|
|
nodes.Node.from_parent(None, config=None) # type: ignore[arg-type]
|
|
|
|
|
|
def test_node_direct_construction_deprecated() -> None:
|
|
with pytest.raises(
|
|
OutcomeException,
|
|
match=(
|
|
"Direct construction of _pytest.nodes.Node has been deprecated, please "
|
|
"use _pytest.nodes.Node.from_parent.\nSee "
|
|
"https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent"
|
|
" for more details."
|
|
),
|
|
):
|
|
nodes.Node(None, session=None) # type: ignore[arg-type]
|
|
|
|
|
|
def test_subclassing_both_item_and_collector_deprecated(
|
|
request, tmp_path: Path
|
|
) -> None:
|
|
"""
|
|
Verifies we warn on diamond inheritance as well as correctly managing legacy
|
|
inheritance constructors with missing args as found in plugins.
|
|
"""
|
|
# We do not expect any warnings messages to issued during class definition.
|
|
with warnings.catch_warnings():
|
|
warnings.simplefilter("error")
|
|
|
|
class SoWrong(nodes.Item, nodes.File):
|
|
def __init__(self, path, parent):
|
|
"""Legacy ctor with legacy call # don't wana see"""
|
|
super().__init__(parent, path)
|
|
|
|
def collect(self):
|
|
raise NotImplementedError()
|
|
|
|
def runtest(self):
|
|
raise NotImplementedError()
|
|
|
|
with pytest.warns(PytestWarning) as rec:
|
|
SoWrong.from_parent(request.session, path=tmp_path / "broken.txt", wrong=10)
|
|
messages = [str(x.message) for x in rec]
|
|
assert any(
|
|
re.search(".*SoWrong.* not using a cooperative constructor.*", x)
|
|
for x in messages
|
|
)
|
|
assert any(
|
|
re.search("(?m)SoWrong .* should not be a collector", x) for x in messages
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"warn_type, msg", [(DeprecationWarning, "deprecated"), (PytestWarning, "pytest")]
|
|
)
|
|
def test_node_warn_is_no_longer_only_pytest_warnings(
|
|
pytester: Pytester, warn_type: Type[Warning], msg: str
|
|
) -> None:
|
|
items = pytester.getitems(
|
|
"""
|
|
def test():
|
|
pass
|
|
"""
|
|
)
|
|
with pytest.warns(warn_type, match=msg):
|
|
items[0].warn(warn_type(msg))
|
|
|
|
|
|
def test_node_warning_enforces_warning_types(pytester: Pytester) -> None:
|
|
items = pytester.getitems(
|
|
"""
|
|
def test():
|
|
pass
|
|
"""
|
|
)
|
|
with pytest.raises(
|
|
ValueError, match="warning must be an instance of Warning or subclass"
|
|
):
|
|
items[0].warn(Exception("ok")) # type: ignore[arg-type]
|
|
|
|
|
|
def test__check_initialpaths_for_relpath() -> None:
|
|
"""Ensure that it handles dirs, and does not always use dirname."""
|
|
cwd = Path.cwd()
|
|
|
|
class FakeSession1:
|
|
_initialpaths = frozenset({cwd})
|
|
|
|
session = cast(pytest.Session, FakeSession1)
|
|
|
|
assert nodes._check_initialpaths_for_relpath(session, cwd) == ""
|
|
|
|
sub = cwd / "file"
|
|
|
|
class FakeSession2:
|
|
_initialpaths = frozenset({cwd})
|
|
|
|
session = cast(pytest.Session, FakeSession2)
|
|
|
|
assert nodes._check_initialpaths_for_relpath(session, sub) == "file"
|
|
|
|
outside = Path("/outside-this-does-not-exist")
|
|
assert nodes._check_initialpaths_for_relpath(session, outside) is None
|
|
|
|
|
|
def test_failure_with_changed_cwd(pytester: Pytester) -> None:
|
|
"""
|
|
Test failure lines should use absolute paths if cwd has changed since
|
|
invocation, so the path is correct (#6428).
|
|
"""
|
|
p = pytester.makepyfile(
|
|
"""
|
|
import os
|
|
import pytest
|
|
|
|
@pytest.fixture
|
|
def private_dir():
|
|
out_dir = 'ddd'
|
|
os.mkdir(out_dir)
|
|
old_dir = os.getcwd()
|
|
os.chdir(out_dir)
|
|
yield out_dir
|
|
os.chdir(old_dir)
|
|
|
|
def test_show_wrong_path(private_dir):
|
|
assert False
|
|
"""
|
|
)
|
|
result = pytester.runpytest()
|
|
result.stdout.fnmatch_lines([str(p) + ":*: AssertionError", "*1 failed in *"])
|