floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
pytest2/testing
History
Ran Benita 992d0f082f fixtures: match fixtures based on actual node hierarchy, not textual nodeids 
Refs #11662.

--- Problem

Each fixture definition has a "visibility", the `FixtureDef.baseid`
attribute. This is nodeid-like string. When a certain `node` requests a
certain fixture name, we match node's nodeid against the fixture
definitions with this name.

The matching currently happens on the *textual* representation of the
nodeid - we split `node.nodeid` to its "parent nodeids" and then check
if the fixture's `baseid` is in there.

While this has worked so far, we really should try to avoid textual
manipulation of nodeids as much as possible. It has also caused problem
in an odd case of a `Package` in the root directory: the `Package` gets
nodeid `.`, while a `Module` in it gets nodeid `test_module.py`. And
textually, `.` is not a parent of `test_module.py`.

--- Solution

Avoid this entirely by just checking the node hierarchy itself. This is
made possible by the fact that we now have proper `Directory` nodes
(`Dir` or `Package`) for the entire hierarchy.

Also do the same for `_getautousenames` which is a similar deal.

The `iterparentnodeids` function is no longer used and is removed.
 		2024-01-08 21:36:51 +02:00
..
_py XFAIL TestLocalPath.test_make_numbered_dir_multiprocess_safe (#11611) 2023-11-14 11:41:35 -03:00
code pytester: use monkeypatch.chdir() for dir changing 2023-09-25 11:31:09 +03:00
example_scripts Rework Session and Package collection 2023-12-10 17:01:39 +02:00
examples fix bug in test for issue 519 2021-03-07 15:01:39 +01:00
freeze testing: fix some docstring issues 2020-08-03 10:10:43 +03:00
io terminalwriter: fix crash trying to highlight empty source 2024-01-02 19:37:24 +02:00
logging Add new filtering() method to LogCaptureFixture class (#11625) 2023-11-24 09:38:34 -03:00
plugins_integration fixtures: match fixtures based on actual node hierarchy, not textual nodeids 2024-01-08 21:36:51 +02:00
python fixtures: match fixtures based on actual node hierarchy, not textual nodeids 2024-01-08 21:36:51 +02:00
acceptance_test.py Rework Session and Package collection 2023-12-10 17:01:39 +02:00
conftest.py Reset color-related envvars for testing (#11638) 2023-11-26 11:09:18 -03:00
deprecated_test.py Remove deprecated py.path (`fspath`) node constructor arguments 2024-01-03 14:29:45 +02:00
test_argcomplete.py pytest-dev#8204 migrate some tests to tmp_path fixture (#8209) 2021-01-01 17:25:11 +02:00
test_assertion.py Merge pull request #11646 from bluetech/pkg-collect 2023-12-30 12:51:48 +02:00
test_assertrewrite.py Add verbosity_assertions and config.get_verbosity 2023-11-19 11:56:29 -03:00
test_cacheprovider.py Rework Session and Package collection 2023-12-10 17:01:39 +02:00
test_capture.py Add encoding in more tests 2023-06-20 04:55:40 -07:00
test_collection.py nodes: fix tracebacks from collection errors are not getting pruned (#11711) 2023-12-31 10:14:23 +02:00
test_compat.py Drop Python 3.7 2023-06-30 14:55:42 -07:00
test_config.py Remove deprecated `pytest_cmdline_preparse` hook 2024-01-02 12:20:47 +02:00
test_conftest.py config: split _getconftestmodules and _loadconftestmodules 2023-08-01 09:46:17 +03:00
test_debugging.py Test fix 2022-10-14 13:53:06 -04:00
test_doctest.py Fix doctest collection of `functools.cached_property` objects. 2023-08-16 00:55:16 -06:00
test_entry_points.py Drop Python 3.7 2023-06-30 14:55:42 -07:00
test_error_diffs.py Improve the full diff by having more consistent indentation in the PrettyPrinter (#11571) 2023-11-27 16:47:18 +02:00
test_faulthandler.py Only re-enable fauthandler during unconfigure if it was enabled before 2021-01-25 12:28:00 -03:00
test_findpaths.py Fix bug where file system root was erroneously be used as rootdir on Windows 2022-11-23 14:46:00 -03:00
test_helpconfig.py Document the --code-highlight default (#9883) 2022-05-31 16:32:51 -03:00
test_junitxml.py Fix user_properties not saved to XML if fixture errors during teardown 2023-09-03 14:33:54 -03:00
test_legacypath.py Remove deprecated py.path (`fspath`) node constructor arguments 2024-01-03 14:29:45 +02:00
test_link_resolve.py Add encoding in more tests 2023-06-20 04:55:40 -07:00
test_main.py Fix crash when passing a very long cmdline argument (#11404) 2023-09-07 12:49:25 -03:00
test_mark.py Rework Session and Package collection 2023-12-10 17:01:39 +02:00
test_mark_expression.py Support forwardslash characters in identifiers (#9249) 2021-11-01 08:54:18 +02:00
test_meta.py py36+: com2ann 2020-10-05 18:33:17 -07:00
test_monkeypatch.py Add encoding in more tests 2023-06-20 04:55:40 -07:00
test_nodes.py fixtures: match fixtures based on actual node hierarchy, not textual nodeids 2024-01-08 21:36:51 +02:00
test_parseopt.py Remove deprecated `Parser.addoption` backward compatibilities 2024-01-02 12:20:47 +02:00
test_pastebin.py fix typing issues in mypy 0.920 2021-12-21 20:42:32 -05:00
test_pathlib.py pytester: use monkeypatch.chdir() for dir changing 2023-09-25 11:31:09 +03:00
test_pluginmanager.py Fixes for typed pluggy 2023-08-26 22:13:24 +03:00
test_pytester.py pytester: use monkeypatch.chdir() for dir changing 2023-09-25 11:31:09 +03:00
test_python_path.py Switch to new-style pluggy hook wrappers 2023-07-14 22:47:48 +03:00
test_recwarn.py Remove deprecated `pytest.warns(None)` 2024-01-02 12:20:47 +02:00
test_reports.py Rework Session and Package collection 2023-12-10 17:01:39 +02:00
test_runner.py Fix teardown error reporting when `--maxfail=1` (#11721) 2024-01-03 19:39:24 +02:00
test_runner_xunit.py [pre-commit.ci] pre-commit autoupdate (#8201) 2020-12-30 11:56:09 +02:00
test_scope.py Refactor internal scope handling by introducing Scope enum 2021-08-01 06:11:56 -03:00
test_session.py Fix teardown error reporting when `--maxfail=1` (#11721) 2024-01-03 19:39:24 +02:00
test_setuponly.py Migrate test_setuponly.py from testdir to pytester (#7959) 2020-10-29 09:55:30 +02:00
test_setupplan.py #7942 test_setupplan.py migrate from testdir to Pytester (#8004) 2020-11-07 09:29:45 -03:00
test_skipping.py Remove deprecated pytest.{exit,fail,skip}(msg=...) argument 2024-01-02 12:20:47 +02:00
test_stash.py Fix typos (#9424) 2021-12-27 09:23:15 -03:00
test_stepwise.py Add encoding in more tests 2023-06-20 04:55:40 -07:00
test_terminal.py Merge pull request #11646 from bluetech/pkg-collect 2023-12-30 12:51:48 +02:00
test_threadexception.py Drop Python 3.7 2023-06-30 14:55:42 -07:00
test_tmpdir.py Remove deprecated `pytest.warns(None)` 2024-01-02 12:20:47 +02:00
test_unittest.py Switch to new-style pluggy hook wrappers 2023-07-14 22:47:48 +03:00
test_unraisableexception.py Explicit GC for PyPy, take 2 2023-06-30 20:33:12 -07:00
test_warning_types.py fix #10342: put location into warning exceptions 2022-10-06 11:44:05 +02:00
test_warnings.py Remove `PytestRemovedIn8Warning` 2024-01-03 14:29:45 +02:00
typing_checks.py monkeypatch: add support for TypedDict (#11000) 2023-05-14 22:17:00 +03:00