3a0a0c2df9
Descriptors (e.g. properties) such as in the added test case are
triggered during collection, executing arbitrary code which can raise.
Previously, such exceptions were propagated and failed the collection.
Now these exceptions are caught and the corresponding attributes are
silently ignored.
A better solution would be to completely skip access to all custom
descriptors, such that the offending code doesn't even trigger. However
I think this requires manually going through the instance and all of its
MRO for each and every attribute checking if it might be a proper
fixture before accessing it. So I took the easy route here.
In other words, putting something like this in your test class is still
a bad idea...:
@property
def innocent(self):
os.system('rm -rf /')
Fixes #2234.
149 lines
2.2 KiB
Plaintext
149 lines
2.2 KiB
Plaintext
Holger Krekel, holger at merlinux eu
|
|
merlinux GmbH, Germany, office at merlinux eu
|
|
|
|
Contributors include::
|
|
|
|
Abdeali JK
|
|
Abhijeet Kasurde
|
|
Ahn Ki-Wook
|
|
Alexei Kozlenok
|
|
Anatoly Bubenkoff
|
|
Andreas Zeidler
|
|
Andrzej Ostrowski
|
|
Andy Freeland
|
|
Anthon van der Neut
|
|
Antony Lee
|
|
Armin Rigo
|
|
Aron Curzon
|
|
Aviv Palivoda
|
|
Barney Gale
|
|
Ben Webb
|
|
Benjamin Peterson
|
|
Bernard Pratz
|
|
Bob Ippolito
|
|
Brian Dorsey
|
|
Brian Okken
|
|
Brianna Laugher
|
|
Bruno Oliveira
|
|
Cal Leeming
|
|
Carl Friedrich Bolz
|
|
Charles Cloud
|
|
Charnjit SiNGH (CCSJ)
|
|
Chris Lamb
|
|
Christian Boelsen
|
|
Christian Theunert
|
|
Christian Tismer
|
|
Christopher Gilling
|
|
Daniel Grana
|
|
Daniel Hahler
|
|
Daniel Nuri
|
|
Daniel Wandschneider
|
|
Danielle Jenkins
|
|
Dave Hunt
|
|
David Díaz-Barquero
|
|
David Mohr
|
|
David Vierra
|
|
Diego Russo
|
|
Dmitry Dygalo
|
|
Duncan Betts
|
|
Edison Gustavo Muenz
|
|
Edoardo Batini
|
|
Eduardo Schettino
|
|
Eli Boyarski
|
|
Elizaveta Shashkova
|
|
Endre Galaczi
|
|
Eric Hunsberger
|
|
Eric Siegerman
|
|
Erik M. Bray
|
|
Feng Ma
|
|
Florian Bruhin
|
|
Floris Bruynooghe
|
|
Gabriel Reis
|
|
Georgy Dyuldin
|
|
Graham Horler
|
|
Greg Price
|
|
Grig Gheorghiu
|
|
Grigorii Eremeev (budulianin)
|
|
Guido Wesdorp
|
|
Harald Armin Massa
|
|
Ian Bicking
|
|
Jaap Broekhuizen
|
|
Jan Balster
|
|
Janne Vanhala
|
|
Jason R. Coombs
|
|
Javier Domingo Cansino
|
|
Javier Romero
|
|
Jeff Widman
|
|
John Towler
|
|
Jon Sonesen
|
|
Jordan Guymon
|
|
Joshua Bronson
|
|
Jurko Gospodnetić
|
|
Justyna Janczyszyn
|
|
Kale Kundert
|
|
Katarzyna Jachim
|
|
Kevin Cox
|
|
Lee Kamentsky
|
|
Lev Maximov
|
|
Loic Esteve
|
|
Lukas Bednar
|
|
Luke Murphy
|
|
Maciek Fijalkowski
|
|
Maho
|
|
Marc Schlaich
|
|
Marcin Bachry
|
|
Mark Abramowitz
|
|
Markus Unterwaditzer
|
|
Martijn Faassen
|
|
Martin K. Scherer
|
|
Martin Prusse
|
|
Mathieu Clabaut
|
|
Matt Bachmann
|
|
Matt Williams
|
|
Matthias Hafner
|
|
mbyt
|
|
Michael Aquilina
|
|
Michael Birtwell
|
|
Michael Droettboom
|
|
Michael Seifert
|
|
Mike Lundy
|
|
Ned Batchelder
|
|
Neven Mundar
|
|
Nicolas Delaby
|
|
Oleg Pidsadnyi
|
|
Oliver Bestwalter
|
|
Omar Kohl
|
|
Pieter Mulder
|
|
Piotr Banaszkiewicz
|
|
Punyashloka Biswal
|
|
Quentin Pradet
|
|
Ralf Schmitt
|
|
Ran Benita
|
|
Raphael Pierzina
|
|
Raquel Alegre
|
|
Roberto Polli
|
|
Romain Dorgueil
|
|
Roman Bolshakov
|
|
Ronny Pfannschmidt
|
|
Ross Lawley
|
|
Russel Winder
|
|
Ryan Wooden
|
|
Samuele Pedroni
|
|
Simon Gomizelj
|
|
Stefan Farmbauer
|
|
Stefan Zimmermann
|
|
Stefano Taschini
|
|
Steffen Allner
|
|
Stephan Obermann
|
|
Tareq Alayan
|
|
Ted Xiao
|
|
Thomas Grainger
|
|
Tom Viner
|
|
Trevor Bekolay
|
|
Tyler Goodlet
|
|
Vasily Kuznetsov
|
|
Victor Uriarte
|
|
Vidar T. Fauske
|
|
Wouter van Ackooy
|
|
Xuecong Liao
|