Merge pull request #1474 from palaviv/improve-idmaker-duplicate-names

Improve idmaker name selection in case of duplicate ids in parametrize

CHANGELOG.rst

@@ -25,8 +25,11 @@
 
 * parametrize ids can accept None as specific test id. The
   automatically generated id for that argument will be used.
+  Thanks `@palaviv`_ for the complete PR (`#1468`_).
 
-*
+* improved idmaker name selection in case of duplicate ids in
+  parametrize.
+  Thanks `@palaviv`_ for the complete PR (`#1474`_).
 
 *
 
@@ -34,11 +37,14 @@
 .. _@novas0x2a: https://github.com/novas0x2a
 .. _@kalekundert: https://github.com/kalekundert
 .. _@tareqalayan: https://github.com/tareqalayan
+.. _@palaviv: https://github.com/palaviv
 
 .. _#1428: https://github.com/pytest-dev/pytest/pull/1428
 .. _#1444: https://github.com/pytest-dev/pytest/pull/1444
 .. _#1441: https://github.com/pytest-dev/pytest/pull/1441
 .. _#1454: https://github.com/pytest-dev/pytest/pull/1454
+.. _#1468: https://github.com/pytest-dev/pytest/pull/1468
+.. _#1474: https://github.com/pytest-dev/pytest/pull/1474
 
 
 2.9.2.dev1

_pytest/python.py

@@ -7,6 +7,7 @@ import re
 import types
 import sys
 import math
+import collections
 
 import py
 import pytest
@@ -1152,9 +1153,14 @@ def _idvalset(idx, valset, argnames, idfn, ids):
 def idmaker(argnames, argvalues, idfn=None, ids=None):
     ids = [_idvalset(valindex, valset, argnames, idfn, ids)
            for valindex, valset in enumerate(argvalues)]
-    if len(set(ids)) < len(ids):
+    if len(set(ids)) != len(ids):
-        # user may have provided a bad idfn which means the ids are not unique
+        # The ids are not unique
-        ids = [str(i) + testid for i, testid in enumerate(ids)]
+        duplicates = [testid for testid in ids if ids.count(testid) > 1]
+        counters = collections.defaultdict(lambda: 0)
+        for index, testid in enumerate(ids):
+            if testid in duplicates:
+                ids[index] = testid + str(counters[testid])
+                counters[testid] += 1
     return ids
 
 def showfixtures(config):

testing/python/metafunc.py

@@ -238,9 +238,9 @@ class TestMetafunc:
                                       (20, KeyError()),
                                       ("three", [1, 2, 3]),
         ], idfn=ids)
-        assert result == ["0a-a",
+        assert result == ["a-a0",
-                          "1a-a",
+                          "a-a1",
-                          "2a-a",
+                          "a-a2",
                          ]
 
     @pytest.mark.issue351
@@ -267,10 +267,9 @@ class TestMetafunc:
 
     def test_idmaker_with_ids_unique_names(self):
         from _pytest.python import idmaker
-        result = idmaker(("a", "b"), [(1, 2),
+        result = idmaker(("a"), [1,2,3,4,5],
-                                      (3, 4)],
+                         ids=["a", "a", "b", "c", "b"])
-                         ids=["a", "a"])
+        assert result == ["a0", "a1", "b0", "c", "b1"]
-        assert result == ["0a", "1a"]
 
     def test_addcall_and_parametrize(self):
         def func(x, y): pass
@@ -834,8 +833,8 @@ class TestMetafuncFunctional:
         result = testdir.runpytest("-v")
         assert result.ret == 1
         result.stdout.fnmatch_lines_random([
-            "*test_function*0a*PASSED",
+            "*test_function*a0*PASSED",
-            "*test_function*1a*FAILED"
+            "*test_function*a1*FAILED"
         ])
 
     @pytest.mark.parametrize(("scope", "length"),