From f76a77b06831de9732ed045f32fe94edaec5d189 Mon Sep 17 00:00:00 2001
From: jakkdl <h6+github@pm.me>
Date: Tue, 13 Feb 2024 13:41:21 +0100
Subject: [PATCH] Add test for finalizer in a fixture with a cached exception

---
 testing/python/test_scope_fixture_caching.py | 63 ++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 testing/python/test_scope_fixture_caching.py

diff --git a/testing/python/test_scope_fixture_caching.py b/testing/python/test_scope_fixture_caching.py
new file mode 100644
index 000000000..21594fb1f
--- /dev/null
+++ b/testing/python/test_scope_fixture_caching.py
@@ -0,0 +1,63 @@
+from typing import Generator
+
+import pytest
+
+
+# These tests will fail if run out of order, or selectively ... so they should probably be defined in a different way
+
+executed: list[str] = []
+
+
+#########
+# Make sure setup and finalization is only run once when using fixture multiple times
+# I'm pretty sure there's other tests that checks this already though, though idr fully where
+#########
+@pytest.fixture(scope="class")
+def fixture_1() -> Generator[None, None, None]:
+    executed.append("fix setup")
+    yield
+    executed.append("fix teardown")
+
+
+class TestFixtureCaching:
+    def test_1(self, fixture_1: None) -> None:
+        assert executed == ["fix setup"]
+
+    def test_2(self, fixture_1: None) -> None:
+        assert executed == ["fix setup"]
+
+
+def test_expected_setup_and_teardown() -> None:
+    assert executed == ["fix setup", "fix teardown"]
+
+
+######
+# Make sure setup & finalization is only run once, with a cached exception
+######
+executed_crash: list[str] = []
+
+
+@pytest.fixture(scope="class")
+def fixture_crash(request: pytest.FixtureRequest) -> None:
+    executed_crash.append("fix_crash setup")
+
+    def my_finalizer() -> None:
+        executed_crash.append("fix_crash teardown")
+
+    request.addfinalizer(my_finalizer)
+
+    raise Exception("foo")
+
+
+class TestFixtureCachingException:
+    @pytest.mark.xfail
+    def test_crash_1(self, fixture_crash: None) -> None:
+        assert False
+
+    @pytest.mark.xfail
+    def test_crash_2(self, fixture_crash: None) -> None:
+        assert False
+
+
+def test_crash_expected_setup_and_teardown() -> None:
+    assert executed_crash == ["fix_crash setup", "fix_crash teardown"]