floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't import difflib and pprint up-front 

Builtin plugins need to keep their import time to a minimum.
Therefore it's better to delay importing till you really need it, i.e.
use py.std.* in this case.

--HG--
branch : trunk
This commit is contained in:
Floris Bruynooghe 2010-09-06 19:46:58 +01:00
parent cd013746cf
commit f194b16a09
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
py/_plugin/pytest_assertion.py
View File

@ -1,6 +1,3 @@
import difflib
import pprint
import py import py
import sys import sys
@ -44,7 +41,7 @@ def pytest_assert_compare(op, left, right):
isdict = lambda x: isinstance(x, dict) isdict = lambda x: isinstance(x, dict)
if istext(left): if istext(left):
explanation += [line.strip('\n') for line in explanation += [line.strip('\n') for line in
difflib.ndiff(left.splitlines(), right.splitlines())] py.std.difflib.ndiff(left.splitlines(), right.splitlines())]
elif issquence(left): elif issquence(left):
explanation += _compare_eq_sequence(left, right) explanation += _compare_eq_sequence(left, right)
elif isdict(left): elif isdict(left):
@ -73,5 +70,5 @@ def _compare_eq_sequence(left, right):
def _pprint_diff(left, right): def _pprint_diff(left, right):
"""Make explanation using pprint and difflib""" """Make explanation using pprint and difflib"""
return [line.strip('\n') for line in return [line.strip('\n') for line in
difflib.ndiff(pprint.pformat(left).splitlines(), py.std.difflib.ndiff(py.std.pprint.pformat(left).splitlines(),
pprint.pformat(right).splitlines())] py.std.pprint.pformat(right).splitlines())]