From 211f3c47b5f71c4f1c243591fe7601db95939455 Mon Sep 17 00:00:00 2001 From: Ronny Pfannschmidt Date: Sun, 1 Apr 2018 15:31:22 +0200 Subject: [PATCH 1/3] record_property is no longer experimental --- _pytest/junitxml.py | 5 ----- changelog/3360.trivial | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) create mode 100644 changelog/3360.trivial diff --git a/_pytest/junitxml.py b/_pytest/junitxml.py index 5207c2514..3a0e4a071 100644 --- a/_pytest/junitxml.py +++ b/_pytest/junitxml.py @@ -245,11 +245,6 @@ def record_property(request): def test_function(record_property): record_property("example_key", 1) """ - request.node.warn( - code='C3', - message='record_property is an experimental feature', - ) - def append_property(name, value): request.node.user_properties.append((name, value)) return append_property diff --git a/changelog/3360.trivial b/changelog/3360.trivial new file mode 100644 index 000000000..3b0e89e1f --- /dev/null +++ b/changelog/3360.trivial @@ -0,0 +1,2 @@ +record_property is no longer experimental, removing the warnings was forgotten. + From 7c0c91a7a291b27f1555d47d899a1ff61dee1d48 Mon Sep 17 00:00:00 2001 From: Ronny Pfannschmidt Date: Tue, 3 Apr 2018 08:00:57 +0200 Subject: [PATCH 2/3] fix record_property test --- testing/test_junitxml.py | 1 - 1 file changed, 1 deletion(-) diff --git a/testing/test_junitxml.py b/testing/test_junitxml.py index b8bbd888f..3241cf6c1 100644 --- a/testing/test_junitxml.py +++ b/testing/test_junitxml.py @@ -877,7 +877,6 @@ def test_record_property(testdir): pnodes[1].assert_attr(name="foo", value="<1") result.stdout.fnmatch_lines([ 'test_record_property.py::test_record', - '*record_property*experimental*', ]) From 2018cf12b1579b648461d32fe624c06b51a6b696 Mon Sep 17 00:00:00 2001 From: Ronny Pfannschmidt Date: Thu, 5 Apr 2018 14:05:26 +0200 Subject: [PATCH 3/3] fix the record_property test --- testing/test_junitxml.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/testing/test_junitxml.py b/testing/test_junitxml.py index 3241cf6c1..a8f5b9fec 100644 --- a/testing/test_junitxml.py +++ b/testing/test_junitxml.py @@ -868,16 +868,13 @@ def test_record_property(testdir): def test_record(record_property, other): record_property("foo", "<1"); """) - result, dom = runandparse(testdir, '-rw') + result, dom = runandparse(testdir, '-rwv') node = dom.find_first_by_tag("testsuite") tnode = node.find_first_by_tag("testcase") psnode = tnode.find_first_by_tag('properties') pnodes = psnode.find_by_tag('property') pnodes[0].assert_attr(name="bar", value="1") pnodes[1].assert_attr(name="foo", value="<1") - result.stdout.fnmatch_lines([ - 'test_record_property.py::test_record', - ]) def test_record_property_same_name(testdir):