fixtures: fix catastrophic performance problem in reorder_items
Fix #12355. In the issue, it was reported that the `reorder_items` has quadratic (or worse...) behavior with certain simple parametrizations. After some debugging I found that the problem happens because the "Fix items_by_argkey order" loop keeps adding the same item to the deque, and it reaches epic sizes which causes the slowdown. I don't claim to understand how the `reorder_items` algorithm works, but if as far as I understand, if an item already exists in the deque, the correct thing to do is to move it to the front. Since a deque doesn't have such an (efficient) operation, this switches to `OrderedDict` which can efficiently append from both sides, deduplicate and move to front.
This commit is contained in:
@@ -2219,6 +2219,25 @@ class TestAutouseManagement:
|
||||
reprec = pytester.inline_run("-s")
|
||||
reprec.assertoutcome(passed=2)
|
||||
|
||||
def test_reordering_catastrophic_performance(self, pytester: Pytester) -> None:
|
||||
"""Check that a certain high-scope parametrization pattern doesn't cause
|
||||
a catasrophic slowdown.
|
||||
|
||||
Regression test for #12355.
|
||||
"""
|
||||
pytester.makepyfile("""
|
||||
import pytest
|
||||
|
||||
params = tuple("abcdefghijklmnopqrstuvwxyz")
|
||||
@pytest.mark.parametrize(params, [range(len(params))] * 3, scope="module")
|
||||
def test_parametrize(a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z):
|
||||
pass
|
||||
""")
|
||||
|
||||
result = pytester.runpytest()
|
||||
|
||||
result.assert_outcomes(passed=3)
|
||||
|
||||
|
||||
class TestFixtureMarker:
|
||||
def test_parametrize(self, pytester: Pytester) -> None:
|
||||
|
||||
Reference in New Issue
Block a user