floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix bug on approx on dict when the order is not the same

This commit is contained in:
Yechiel Vizel 2024-06-10 12:10:52 +00:00
parent f3946dce07
commit e05c5c64b9
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
AUTHORS
View File

@ -292,6 +292,7 @@ Milan Lesnek
Miro Hrončok Miro Hrončok
mrbean-bremen mrbean-bremen
Nathan Goldbaum Nathan Goldbaum
Nathan Sala
Nathaniel Compton Nathaniel Compton
Nathaniel Waisbrot Nathaniel Waisbrot
Ned Batchelder Ned Batchelder
@ -442,6 +443,7 @@ Xuan Luong
Xuecong Liao Xuecong Liao
Yannick Péroux Yannick Péroux
Yao Xiao Yao Xiao
Yechiel Vizel
Yoav Caspi Yoav Caspi
Yuliang Shao Yuliang Shao
Yusuke Kadowaki Yusuke Kadowaki

1
changelog/12444.bugfix.rst Normal file
View File

@ -0,0 +1 @@
Fix approx wrong error description, when using to compare 2 dicts which are not in the same order - printing all values as wrong.

5
src/_pytest/python_api.py
View File

@ -255,9 +255,8 @@ class ApproxMapping(ApproxBase):
max_abs_diff = -math.inf max_abs_diff = -math.inf
max_rel_diff = -math.inf max_rel_diff = -math.inf
different_ids = [] different_ids = []
for (approx_key, approx_value), other_value in zip( for approx_key, approx_value in approx_side_as_map.items():
approx_side_as_map.items(), other_side.values() other_value = other_side[approx_key]
):
if approx_value != other_value: if approx_value != other_value:
if approx_value.expected is not None and other_value is not None: if approx_value.expected is not None and other_value is not None:
max_abs_diff = max( max_abs_diff = max(