From d97fe5663b139fc6bb20c3ed70f1181e7547bbad Mon Sep 17 00:00:00 2001 From: dheerajck Date: Fri, 19 Apr 2024 00:08:45 +0530 Subject: [PATCH] Replaced os.environ["PYTEST_VERSION"] = "old version" by monkeypatch.setenv("PYTEST_VERSION", "old version") to ensure this env variable is cleaned up after this ut, its a good practise to make sure one ut doesnt affect other uts unless theres a specific reason --- testing/test_runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/test_runner.py b/testing/test_runner.py index d3ddc5d9a..ffac0f2d9 100644 --- a/testing/test_runner.py +++ b/testing/test_runner.py @@ -1097,7 +1097,7 @@ def test_outcome_exception_bad_msg() -> None: def test_pytest_version_env_var(pytester: Pytester, monkeypatch: MonkeyPatch) -> None: - os.environ["PYTEST_VERSION"] = "old version" + monkeypatch.setenv("PYTEST_VERSION", "old version") pytester.makepyfile( """ import pytest