floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #6538 from blueyed/test-coverage 

tests: use NotImplementedError with uncovered code
This commit is contained in:
Daniel Hahler 2020-01-22 16:45:20 +01:00 committed by GitHub
parent 8c4dfca0c1 d878d9d4d5
commit ba49581510
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
testing/test_runner.py
View File

@ -557,7 +557,7 @@ def test_outcomeexception_passes_except_Exception() -> None:
try: try:
raise outcomes.OutcomeException("test") raise outcomes.OutcomeException("test")
except Exception: except Exception:
pass raise NotImplementedError()
def test_pytest_exit() -> None: def test_pytest_exit() -> None:
@ -740,8 +740,9 @@ def test_importorskip(monkeypatch) -> None:
mod2 = pytest.importorskip("hello123", minversion="1.3") mod2 = pytest.importorskip("hello123", minversion="1.3")
assert mod2 == mod assert mod2 == mod
except Skipped: except Skipped:
print(_pytest._code.ExceptionInfo.from_current()) raise NotImplementedError(
pytest.fail("spurious skip") "spurious skip: {}".format(_pytest._code.ExceptionInfo.from_current())
)
def test_importorskip_imports_last_module_part() -> None: def test_importorskip_imports_last_module_part() -> None:
@ -759,8 +760,9 @@ def test_importorskip_dev_module(monkeypatch) -> None:
with pytest.raises(Skipped): with pytest.raises(Skipped):
pytest.importorskip("mockmodule1", minversion="0.14.0") pytest.importorskip("mockmodule1", minversion="0.14.0")
except Skipped: except Skipped:
print(_pytest._code.ExceptionInfo.from_current()) raise NotImplementedError(
pytest.fail("spurious skip") "spurious skip: {}".format(_pytest._code.ExceptionInfo.from_current())
)
def test_importorskip_module_level(testdir) -> None: def test_importorskip_module_level(testdir) -> None:
@ -1030,7 +1032,7 @@ def test_outcome_exception_bad_msg() -> None:
"""Check that OutcomeExceptions validate their input to prevent confusing errors (#5578)""" """Check that OutcomeExceptions validate their input to prevent confusing errors (#5578)"""
def func() -> None: def func() -> None:
pass raise NotImplementedError()
expected = ( expected = (
"OutcomeException expected string as 'msg' parameter, got 'function' instead.\n" "OutcomeException expected string as 'msg' parameter, got 'function' instead.\n"