From b8255308d65d91a464991259b0b233dcc4969486 Mon Sep 17 00:00:00 2001 From: Kale Kundert Date: Wed, 1 Aug 2018 12:08:03 -0700 Subject: [PATCH] Make the infinite-recusrion fix more explicit. So we remember what happened and don't accidentally regress in the future. --- src/_pytest/python_api.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/_pytest/python_api.py b/src/_pytest/python_api.py index 411562eb8..596bac191 100644 --- a/src/_pytest/python_api.py +++ b/src/_pytest/python_api.py @@ -211,7 +211,9 @@ class ApproxScalar(ApproxBase): the pre-specified tolerance. """ if _is_numpy_array(actual): - return all(self == a for a in actual.flat) + # Call ``__eq__()`` manually to prevent infinite-recursion with + # numpy<1.13. See #3748. + return all(self.__eq__(a) for a in actual.flat) # Short-circuit exact equality. if actual == self.expected: