From b61719d479eb8c6c37234e7f865d187dbe50f7a9 Mon Sep 17 00:00:00 2001 From: TanyaAgarwal28 <8979149361t@gmail.com> Date: Wed, 11 Oct 2023 12:57:09 +0530 Subject: [PATCH] Bug Fix 11282: config.getini returns an empty list for an option of type string absent in INI file --- testing/test_conftest.py | 43 ++++++++++++++-------------------------- 1 file changed, 15 insertions(+), 28 deletions(-) diff --git a/testing/test_conftest.py b/testing/test_conftest.py index 52df31dbd..058b40c58 100644 --- a/testing/test_conftest.py +++ b/testing/test_conftest.py @@ -223,37 +223,24 @@ def test_setinitial_conftest_subdirs(pytester: Pytester, name: str) -> None: def test_my_option(pytester: Pytester): testdir = pytester.mkdir("test_my_option") - testdir.joinpath("conftest.py").write_text( - textwrap.dedent( - """\ - def pytest_addoption(parser): - parser.addini( - "my_option", - type="string", - default=None, - help="My option", - ) - @pytest.fixture(scope='session') - def my_option(request): - return request.config.getini("my_option") - """ - ), - encoding="utf-8", - ) + conftest_content = """ + def pytest_addoption(parser): + parser.addini( + "my_option", + type="string", + default=None, + help="My option", + ) + """ + testdir.joinpath("conftest.py").write_text(conftest_content, encoding="utf-8") # Create a simple test function - testdir.joinpath("test_my_option.py").write_text( - textwrap.dedent( - """\ - def test_example(my_option): - assert my_option is None - """ - ), - encoding="utf-8", - ) + test_content = """ + def test_example(my_option): + assert my_option is None + """ + testdir.joinpath("test_my_option.py").write_text(test_content, encoding="utf-8") result = pytester.runpytest(str(testdir)) assert result.ret == 0 - captured_stdout = result.stdout.str() - assert "1 passed" in captured_stdout def test_conftest_confcutdir(pytester: Pytester) -> None: