From 9950fdc3ebdd2274e241cb1ab7f9659b524390c6 Mon Sep 17 00:00:00 2001 From: holger krekel Date: Tue, 12 May 2009 11:05:05 +0200 Subject: [PATCH] bring back nicer headlines for failure tests --HG-- branch : trunk --- py/test/plugin/pytest_terminal.py | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/py/test/plugin/pytest_terminal.py b/py/test/plugin/pytest_terminal.py index f2db75271..d73e5260e 100644 --- a/py/test/plugin/pytest_terminal.py +++ b/py/test/plugin/pytest_terminal.py @@ -270,6 +270,13 @@ class TerminalReporter: line = "[nometainfo]" return line % locals() + " " + def _getfailureheadline(self, rep): + if isinstance(rep.colitem, py.test.collect.Collector): + return str(rep.colitem.fspath) + else: + fspath, lineno, msg = rep.colitem.metainfo() + return msg + # # summaries for testrunfinish # @@ -277,13 +284,14 @@ class TerminalReporter: def summary_failures(self): if 'failed' in self.stats and self.config.option.tbstyle != "no": self.write_sep("=", "FAILURES") - for ev in self.stats['failed']: - self.write_sep("_", "FAILURES") - if hasattr(ev, 'node'): + for rep in self.stats['failed']: + msg = self._getfailureheadline(rep) + self.write_sep("_", msg) + if hasattr(rep, 'node'): self.write_line(self.gateway2info.get( - ev.node.gateway, "node %r (platinfo not found? strange)") + rep.node.gateway, "node %r (platinfo not found? strange)") [:self._tw.fullwidth-1]) - ev.toterminal(self._tw) + rep.toterminal(self._tw) def summary_stats(self): session_duration = py.std.time.time() - self._sessionstarttime