From 9869a3d9e1e270d623c96c47a2c8ab198e007087 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Tue, 21 Jan 2020 20:21:03 +0100 Subject: [PATCH] ci: GHA: remove unnecessary check for `success()` Following jobs get aborted on failure. Ref: https://github.com/pytest-dev/pytest/pull/6530 --- .github/workflows/main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index aca64f350..8a5ddbda4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -138,18 +138,18 @@ jobs: run: "tox -e ${{ matrix.tox_env }}" - name: Prepare coverage token - if: success() && !matrix.skip_coverage && ( github.repository == 'pytest-dev/pytest' || github.event_name == 'pull_request' ) + if: (!matrix.skip_coverage && ( github.repository == 'pytest-dev/pytest' || github.event_name == 'pull_request' )) run: | python scripts/append_codecov_token.py - name: Combine coverage - if: success() && !matrix.skip_coverage + if: (!matrix.skip_coverage) run: | python -m coverage combine python -m coverage xml - name: Codecov upload - if: success() && !matrix.skip_coverage + if: (!matrix.skip_coverage) uses: codecov/codecov-action@v1 with: token: ${{ secrets.codecov }}