Fix/improve comparison of byte strings

Fixes https://github.com/pytest-dev/pytest/issues/5260.
2019-05-15 12:03:00 +02:00
parent 64a6365227
commit 8c7eb82363
3 changed files with 17 additions and 1 deletions
--- a/src/_pytest/assertion/util.py
+++ b/src/_pytest/assertion/util.py
@@ -263,8 +263,11 @@ def _compare_eq_sequence(left, right, verbose=0):
                "At index {} diff: {!r} != {!r}".format(i, left[i], right[i])
            ]
            break
-    len_diff = len_left - len_right

+    if isinstance(left, bytes):
+        return explanation
+
+    len_diff = len_left - len_right
    if len_diff:
        if len_diff > 0:
            dir_with_more = "Left"