From 1dd5f088faed8248f06b3ef59b8e38b0c249e4c3 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Sun, 14 Apr 2019 21:55:15 +0200 Subject: [PATCH 1/2] test_pytest_exit_returncode: ignore ResourceWarnings Fixes https://github.com/pytest-dev/pytest/issues/5088. --- testing/test_runner.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/testing/test_runner.py b/testing/test_runner.py index cf335dfad..ec144dc0e 100644 --- a/testing/test_runner.py +++ b/testing/test_runner.py @@ -581,7 +581,14 @@ def test_pytest_exit_returncode(testdir): ) result = testdir.runpytest() result.stdout.fnmatch_lines(["*! *Exit: some exit msg !*"]) - assert result.stderr.lines == [""] + # Assert no output on stderr, except for unreliable ResourceWarnings. + # (https://github.com/pytest-dev/pytest/issues/5088) + assert [ + x + for x in result.stderr.lines + if not x.startswith("Exception ignored in:") + and not x.startswith("ResourceWarning") + ] == [""] assert result.ret == 99 # It prints to stderr also in case of exit during pytest_sessionstart. From f1f1862b1950f90ccca4e20fbd73bf4e3c6f56bf Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Sun, 14 Apr 2019 23:26:56 +0200 Subject: [PATCH 2/2] Update testing/test_runner.py --- testing/test_runner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testing/test_runner.py b/testing/test_runner.py index ec144dc0e..c52d2ea7c 100644 --- a/testing/test_runner.py +++ b/testing/test_runner.py @@ -581,7 +581,7 @@ def test_pytest_exit_returncode(testdir): ) result = testdir.runpytest() result.stdout.fnmatch_lines(["*! *Exit: some exit msg !*"]) - # Assert no output on stderr, except for unreliable ResourceWarnings. + # Assert no output on stderr, except for unreliable ResourceWarnings. # (https://github.com/pytest-dev/pytest/issues/5088) assert [ x