floraachy/pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

logging: improve default logging format (issue5214)

Browse Source 
We improve the following things in the logging format:

  * Show module name instead of just the filename
  * show level of logging as the first thing
  * show lineno attached to module:file details

Thanks to @blueyed who suggested this on the github issue.

It's my first contribution and I have added myself to AUTHORS.

I also added to a changelog file.
This commit is contained in:
Pulkit Goyal
2019-05-07 23:22:48 +03:00
parent 2051e30b9b
commit 7e08e09473
4 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
testing/logging/test_reporting.py
View File

@@ -248,7 +248,7 @@ def test_log_cli_enabled_disabled(testdir, enabled):
[
"test_log_cli_enabled_disabled.py::test_log_cli ",
"*-- live log call --*",
"test_log_cli_enabled_disabled.py* CRITICAL critical message logged by test",
"CRITICAL *test_log_cli_enabled_disabled.py* critical message logged by test",
"PASSED*",
]
)
@@ -282,7 +282,7 @@ def test_log_cli_default_level(testdir):
result.stdout.fnmatch_lines(
[
"test_log_cli_default_level.py::test_log_cli ",
"test_log_cli_default_level.py*WARNING message will be shown*",
"WARNING*test_log_cli_default_level.py* message will be shown*",
]
)
assert "INFO message won't be shown" not in result.stdout.str()
@@ -523,7 +523,7 @@ def test_sections_single_new_line_after_test_outcome(testdir, request):
)
assert (
re.search(
r"(.+)live log teardown(.+)\n(.+)WARNING(.+)\n(.+)WARNING(.+)",
r"(.+)live log teardown(.+)\nWARNING(.+)\nWARNING(.+)",
result.stdout.str(),
re.MULTILINE,
)
@@ -531,7 +531,7 @@ def test_sections_single_new_line_after_test_outcome(testdir, request):
)
assert (
re.search(
r"(.+)live log finish(.+)\n(.+)WARNING(.+)\n(.+)WARNING(.+)",
r"(.+)live log finish(.+)\nWARNING(.+)\nWARNING(.+)",
result.stdout.str(),
re.MULTILINE,
)
@@ -565,7 +565,7 @@ def test_log_cli_level(testdir):
# fnmatch_lines does an assertion internally
result.stdout.fnmatch_lines(
[
"test_log_cli_level.py*This log message will be shown",
"*test_log_cli_level.py*This log message will be shown",
"PASSED", # 'PASSED' on its own line because the log message prints a new line
]
)
@@ -579,7 +579,7 @@ def test_log_cli_level(testdir):
# fnmatch_lines does an assertion internally
result.stdout.fnmatch_lines(
[
"test_log_cli_level.py* This log message will be shown",
"*test_log_cli_level.py* This log message will be shown",
"PASSED", # 'PASSED' on its own line because the log message prints a new line
]
)
@@ -615,7 +615,7 @@ def test_log_cli_ini_level(testdir):
# fnmatch_lines does an assertion internally
result.stdout.fnmatch_lines(
[
"test_log_cli_ini_level.py* This log message will be shown",
"*test_log_cli_ini_level.py* This log message will be shown",
"PASSED", # 'PASSED' on its own line because the log message prints a new line
]
)