nodes: fix tracebacks from collection errors are not getting pruned

Fix #11710.
This commit is contained in:
Ran Benita 2023-12-16 17:32:20 +02:00
parent 047ba83dab
commit 7706286761
3 changed files with 26 additions and 1 deletions

View File

@ -0,0 +1 @@
Fixed tracebacks from collection errors not getting pruned.

View File

@ -579,7 +579,7 @@ class Collector(Node, abc.ABC):
ntraceback = traceback.cut(path=self.path)
if ntraceback == traceback:
ntraceback = ntraceback.cut(excludepath=tracebackcutdir)
return excinfo.traceback.filter(excinfo)
return ntraceback.filter(excinfo)
return excinfo.traceback

View File

@ -16,6 +16,7 @@ from _pytest.nodes import Item
from _pytest.pathlib import symlink_or_skip
from _pytest.pytester import HookRecorder
from _pytest.pytester import Pytester
from _pytest._code.code import ExceptionChainRepr, ReprTraceback
def ensure_file(file_path: Path) -> Path:
@ -345,6 +346,29 @@ class TestPrunetraceback:
result = pytester.runpytest(p)
result.stdout.fnmatch_lines(["*ERROR collecting*", "*header1*"])
def test_collection_error_traceback_is_clean(self, pytester: Pytester) -> None:
"""When a collection error occurs, the report traceback doesn't contain
internal pytest stack entries.
Issue #11710.
"""
pytester.makepyfile(
"""
raise Exception("LOUSY")
"""
)
result = pytester.runpytest()
result.stdout.fnmatch_lines(
[
"*ERROR collecting*",
"test_*.py:1: in <module>",
' raise Exception("LOUSY")',
"E Exception: LOUSY",
"*= short test summary info =*",
],
consecutive=True,
)
class TestCustomConftests:
def test_ignore_collect_path(self, pytester: Pytester) -> None: