floraachy
/
pytest2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace asserts of `any` with an assert in a for

This commit is contained in:
Tomer Keren 2019-04-13 19:13:29 +03:00
parent 6b5152ae13
commit 765f75a8f1
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/_pytest/assertion/rewrite.py
View File

@ -964,6 +964,8 @@ warn_explicit(
""" """
visit `ast.Call` nodes on Python3.5 and after visit `ast.Call` nodes on Python3.5 and after
""" """
if call.func.id == "all":
return self.visit_all(call)
new_func, func_expl = self.visit(call.func) new_func, func_expl = self.visit(call.func)
arg_expls = [] arg_expls = []
new_args = [] new_args = []
@ -987,6 +989,22 @@ warn_explicit(
outer_expl = "%s\n{%s = %s\n}" % (res_expl, res_expl, expl) outer_expl = "%s\n{%s = %s\n}" % (res_expl, res_expl, expl)
return res, outer_expl return res, outer_expl
def visit_all(self, call):
"""Special rewrite for the builtin all function, see #5602"""
if not isinstance(call.args[0], ast.GeneratorExp):
return
gen_exp = call.args[0]
for_loop = ast.For(
iter=gen_exp.generators[0].iter,
target=gen_exp.generators[0].target,
body=[
self.visit(ast.Assert(test=gen_exp.elt, lineno=1, msg="", col_offset=1))
],
)
ast.fix_missing_locations(for_loop)
for_loop = ast.copy_location(for_loop, call)
return for_loop, ""
def visit_Starred(self, starred): def visit_Starred(self, starred):
# From Python 3.5, a Starred node can appear in a function call # From Python 3.5, a Starred node can appear in a function call
res, expl = self.visit(starred.value) res, expl = self.visit(starred.value)